| Message ID | 20180209143937.28866-2-andre.przywara@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | New VGIC(-v2) implementation | expand |
Hi, AFAICT, patch #1-#6 were sent separately and were reviewed. I will skip them for now, but please address the comments on the next version. Cheers, On 02/09/2018 02:38 PM, Andre Przywara wrote: > When creating a GICv3 devicetree node, we currently insert the > redistributor-stride and #redistributor-regions properties, with fixed > values which are actually the architected ones. But those properties are > optional and only needed to cover for broken platforms, where the values > differ from the architected one. This will never be the case for the > constructed DomU memory map. > So we drop those properties altogether and provide a clean and architected > GICv3 DT node for DomUs. > > Signed-off-by: Andre Przywara <andre.przywara@linaro.org> > --- > tools/libxl/libxl_arm.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > index 3e46554301..b5bba3cd33 100644 > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -524,14 +524,6 @@ static int make_gicv3_node(libxl__gc *gc, void *fdt) > res = fdt_property(fdt, "interrupt-controller", NULL, 0); > if (res) return res; > > - res = fdt_property_cell(fdt, "redistributor-stride", > - GUEST_GICV3_RDIST_STRIDE); > - if (res) return res; > - > - res = fdt_property_cell(fdt, "#redistributor-regions", > - GUEST_GICV3_RDIST_REGIONS); > - if (res) return res; > - > res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS, > 2, > gicd_base, gicd_size, >
diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 3e46554301..b5bba3cd33 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -524,14 +524,6 @@ static int make_gicv3_node(libxl__gc *gc, void *fdt) res = fdt_property(fdt, "interrupt-controller", NULL, 0); if (res) return res; - res = fdt_property_cell(fdt, "redistributor-stride", - GUEST_GICV3_RDIST_STRIDE); - if (res) return res; - - res = fdt_property_cell(fdt, "#redistributor-regions", - GUEST_GICV3_RDIST_REGIONS); - if (res) return res; - res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS, 2, gicd_base, gicd_size,
When creating a GICv3 devicetree node, we currently insert the redistributor-stride and #redistributor-regions properties, with fixed values which are actually the architected ones. But those properties are optional and only needed to cover for broken platforms, where the values differ from the architected one. This will never be the case for the constructed DomU memory map. So we drop those properties altogether and provide a clean and architected GICv3 DT node for DomUs. Signed-off-by: Andre Przywara <andre.przywara@linaro.org> --- tools/libxl/libxl_arm.c | 8 -------- 1 file changed, 8 deletions(-)