| Message ID | 20180608123307.24773-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | fix building of tests/tcg | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180608123307.24773-1-alex.bennee@linaro.org
Subject: [Qemu-devel] [PATCH v6 00/49] fix building of tests/tcg
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180608123307.24773-1-alex.bennee@linaro.org -> patchew/20180608123307.24773-1-alex.bennee@linaro.org
Switched to a new branch 'test'
a3b42cec1c .travis.yml: add check-tcg test
9311c8f413 tests/docker: prevent sub-makes re-building debian-sid
09ca6d8e3b tests: add top-level make dependency for docker builds
2e879d658a target/sh4: Fix translator.c assertion failure for gUSA
0af702f272 tests/tcg: override runners for broken tests
7aaea5aa91 tests/tcg: add run, diff, and skip helper macros
e0eaf5b9a7 tests/Makefile.include: add [build|clean|check]-tcg targets
14fd002c16 Makefile.target: add (clean-/build-)guest-tests targets
3d0926618b tests/tcg/Makefile: update to be called from Makefile.target
c88f115914 tests/tcg: enable building for PowerPC
b563a10aac docker: move debian-powerpc-cross to sid based build
734d1f7ede tests/tcg: enable building for RISCV64
22bf732b43 tests/tcg: enable building for mips64
9b84cd6979 tests/tcg: enable building for sparc64
fefb20a640 tests/tcg: enable building for sh4
54483dadbf tests/tcg: enable building for m68k
605c4d05e0 tests/tcg: enable building for HPPA
39c366d478 tests/tcg/alpha: add Alpha specific tests
d007a1df09 tests/tcg: enable building for Alpha
da85acf3b9 tests/tcg: enable building for ppc64
275041e496 tests/tcg: enable building for s390x
76b1b57115 tests/tcg/mips: include common mips hello-mips
3001eff269 tests/tcg: enable building for MIPS
fc2f8e7d15 tests/tcg: move MIPS specific tests into subdir
68015cff55 tests/tcg/arm: add fcvt test cases for AArch32/64
6cf0b6d54f tests/tcg: enable building for AArch64
82a59304e2 tests/tcg/arm: fix up test-arm-iwmmxt test
2d3d6eb162 tests/tcg: enable building for ARM
1010d901f6 tests/tcg: move ARM specific tests into subdir
03414050fb tests/tcg/i386/test-i386: fix printf format
18dc0dd9c2 tests/tcg/i386/test-i386: use modern vector_size attributes
b1060c7415 tests/tcg/x86_64: add Makefile.target
f23ed58cdd tests/tcg/i386: add runner for test-i386-fprem
0d5ea512bb tests/tcg/i386: fix test-i386
6e69457c08 tests/tcg/i386: Build fix for hello-i386
c50f3d900e tests/tcg: enable building for i386
aab757d75e tests/tcg: move i386 specific tests into subdir
d76905d84c tests/tcg/multiarch: move most output to stdout
9138f45c68 tests/tcg/multiarch: enable additional linux-test tests
ced507e550 tests/tcg/multiarch: Build fix for linux-test
02861f0e01 tests/tcg: move architecture independent tests into subdir
2e91417605 docker: Makefile.include introduce DOCKER_SCRIPT
95e4639b49 docker: allow "cc" command to run in user context
638a3973fc docker: extend "cc" command to accept compiler
814faf606c docker: Add "cc" subcommand
cb7522263d configure: set cross_cc_FOO for host compiler
750b722573 configure: allow user to specify --cross-cc-cflags-foo=
00ce60af25 configure: move i386_cc to cross_cc_i386
badb0ec98b configure: add support for --cross-cc-FOO
=== OUTPUT BEGIN ===
Checking PATCH 1/49: configure: add support for --cross-cc-FOO...
Checking PATCH 2/49: configure: move i386_cc to cross_cc_i386...
Checking PATCH 3/49: configure: allow user to specify --cross-cc-cflags-foo=...
Checking PATCH 4/49: configure: set cross_cc_FOO for host compiler...
Checking PATCH 5/49: docker: Add "cc" subcommand...
Checking PATCH 6/49: docker: extend "cc" command to accept compiler...
Checking PATCH 7/49: docker: allow "cc" command to run in user context...
Checking PATCH 8/49: docker: Makefile.include introduce DOCKER_SCRIPT...
Checking PATCH 9/49: tests/tcg: move architecture independent tests into subdir...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#138:
new file mode 100644
total: 0 errors, 1 warnings, 136 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/49: tests/tcg/multiarch: Build fix for linux-test...
ERROR: if this code is redundant consider removing it
#156: FILE: tests/tcg/multiarch/linux-test.c:323:
+#if 0
total: 1 errors, 0 warnings, 185 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/49: tests/tcg/multiarch: enable additional linux-test tests...
Checking PATCH 12/49: tests/tcg/multiarch: move most output to stdout...
ERROR: code indent should never use tabs
#37: FILE: tests/tcg/multiarch/test-mmap.c:60:
+^Ifprintf(stdout, "%s", __func__);$
ERROR: code indent should never use tabs
#46: FILE: tests/tcg/multiarch/test-mmap.c:109:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#55: FILE: tests/tcg/multiarch/test-mmap.c:118:
+^Ifprintf(stdout, "%s", __func__);$
ERROR: code indent should never use tabs
#64: FILE: tests/tcg/multiarch/test-mmap.c:133:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#73: FILE: tests/tcg/multiarch/test-mmap.c:144:
+^Ifprintf(stdout, "%s", __func__);$
ERROR: code indent should never use tabs
#82: FILE: tests/tcg/multiarch/test-mmap.c:183:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#91: FILE: tests/tcg/multiarch/test-mmap.c:197:
+^Ifprintf(stdout, "%s addr=%p", __func__, addr);$
ERROR: code indent should never use tabs
#100: FILE: tests/tcg/multiarch/test-mmap.c:215:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#110: FILE: tests/tcg/multiarch/test-mmap.c:228:
+^Ifprintf(stdout, "%s addr=%p", __func__, addr);$
ERROR: code indent should never use tabs
#111: FILE: tests/tcg/multiarch/test-mmap.c:229:
+^Ifprintf(stdout, "FIXME: QEMU fails to track pages used by the host.");$
ERROR: code indent should never use tabs
#120: FILE: tests/tcg/multiarch/test-mmap.c:246:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#129: FILE: tests/tcg/multiarch/test-mmap.c:255:
+^Ifprintf(stdout, "%s", __func__);$
ERROR: code indent should never use tabs
#138: FILE: tests/tcg/multiarch/test-mmap.c:297:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#147: FILE: tests/tcg/multiarch/test-mmap.c:307:
+^Ifprintf(stdout, "%s", __func__);$
ERROR: code indent should never use tabs
#156: FILE: tests/tcg/multiarch/test-mmap.c:330:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#165: FILE: tests/tcg/multiarch/test-mmap.c:346:
+^Ifprintf(stdout, "%s addr=%p", __func__, (void *)addr);$
ERROR: code indent should never use tabs
#174: FILE: tests/tcg/multiarch/test-mmap.c:374:
+^Ifprintf(stdout, " passed\n");$
ERROR: code indent should never use tabs
#183: FILE: tests/tcg/multiarch/test-mmap.c:387:
+^Ifprintf(stdout, "%s addr=%p", __func__, (void *)addr);$
ERROR: code indent should never use tabs
#192: FILE: tests/tcg/multiarch/test-mmap.c:429:
+^Ifprintf(stdout, " passed\n");$
total: 19 errors, 0 warnings, 154 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/49: tests/tcg: move i386 specific tests into subdir...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84:
new file mode 100644
total: 0 errors, 1 warnings, 120 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/49: tests/tcg: enable building for i386...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 19 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/49: tests/tcg/i386: Build fix for hello-i386...
ERROR: externs should be avoided in .c files
#22: FILE: tests/tcg/i386/hello-i386.c:23:
+void _start(void);
total: 1 errors, 0 warnings, 7 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/49: tests/tcg/i386: fix test-i386...
Checking PATCH 17/49: tests/tcg/i386: add runner for test-i386-fprem...
Checking PATCH 18/49: tests/tcg/x86_64: add Makefile.target...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
total: 0 errors, 1 warnings, 33 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/49: tests/tcg/i386/test-i386: use modern vector_size attributes...
Checking PATCH 20/49: tests/tcg/i386/test-i386: fix printf format...
Checking PATCH 21/49: tests/tcg: move ARM specific tests into subdir...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52:
new file mode 100644
total: 0 errors, 1 warnings, 46 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 22/49: tests/tcg: enable building for ARM...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 21 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 23/49: tests/tcg/arm: fix up test-arm-iwmmxt test...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42:
rename from tests/tcg/arm/test-arm-iwmmxt.s
total: 0 errors, 1 warnings, 14 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/49: tests/tcg: enable building for AArch64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/49: tests/tcg/arm: add fcvt test cases for AArch32/64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
WARNING: architecture specific defines should be avoided
#3430: FILE: tests/tcg/arm/fcvt.c:76:
+# if __GNUC_PREREQ(3, 3)
ERROR: space prohibited between function name and open parenthesis '('
#3431: FILE: tests/tcg/arm/fcvt.c:77:
+# define SNANF (__builtin_nansf (""))
ERROR: space prohibited between function name and open parenthesis '('
#3432: FILE: tests/tcg/arm/fcvt.c:78:
+# define SNAN (__builtin_nans (""))
ERROR: space prohibited between function name and open parenthesis '('
#3433: FILE: tests/tcg/arm/fcvt.c:79:
+# define SNANL (__builtin_nansl (""))
ERROR: spaces required around that '+' (ctx:VxV)
#3441: FILE: tests/tcg/arm/fcvt.c:87:
+ -1.111E+31,
^
ERROR: spaces required around that '+' (ctx:VxV)
#3442: FILE: tests/tcg/arm/fcvt.c:88:
+ -1.111E+30,
^
ERROR: spaces required around that '-' (ctx:VxV)
#3443: FILE: tests/tcg/arm/fcvt.c:89:
+ -1.08700982e-12,
^
ERROR: spaces required around that '-' (ctx:VxV)
#3444: FILE: tests/tcg/arm/fcvt.c:90:
+ -1.78051176e-20,
^
ERROR: spaces required around that '-' (ctx:VxV)
#3448: FILE: tests/tcg/arm/fcvt.c:94:
+ 2.98023224e-08,
^
ERROR: spaces required around that '-' (ctx:VxV)
#3449: FILE: tests/tcg/arm/fcvt.c:95:
+ 5.96046E-8, /* min positive FP16 subnormal */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3450: FILE: tests/tcg/arm/fcvt.c:96:
+ 6.09756E-5, /* max subnormal FP16 */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3451: FILE: tests/tcg/arm/fcvt.c:97:
+ 6.10352E-5, /* min positive normal FP16 */
^
ERROR: spaces required around that '+' (ctx:VxV)
#3462: FILE: tests/tcg/arm/fcvt.c:108:
+ 1.111E+30,
^
WARNING: architecture specific defines should be avoided
#3480: FILE: tests/tcg/arm/fcvt.c:126:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3505: FILE: tests/tcg/arm/fcvt.c:151:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3527: FILE: tests/tcg/arm/fcvt.c:173:
+#if defined(__arm__)
ERROR: spaces required around that '-' (ctx:VxV)
#3548: FILE: tests/tcg/arm/fcvt.c:194:
+ {-FLT_MAX-1.0},
^
ERROR: spaces required around that '+' (ctx:VxV)
#3550: FILE: tests/tcg/arm/fcvt.c:196:
+ {-1.111E+31},
^
ERROR: spaces required around that '+' (ctx:VxV)
#3551: FILE: tests/tcg/arm/fcvt.c:197:
+ {-1.111E+30}, /* half prec */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3557: FILE: tests/tcg/arm/fcvt.c:203:
+ {2.98023224e-08},
^
ERROR: spaces required around that '-' (ctx:VxV)
#3558: FILE: tests/tcg/arm/fcvt.c:204:
+ {5.96046E-8}, /* min positive FP16 subnormal */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3559: FILE: tests/tcg/arm/fcvt.c:205:
+ {6.09756E-5}, /* max subnormal FP16 */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3560: FILE: tests/tcg/arm/fcvt.c:206:
+ {6.10352E-5}, /* min positive normal FP16 */
^
ERROR: spaces required around that '-' (ctx:VxV)
#3564: FILE: tests/tcg/arm/fcvt.c:210:
+ {1.3789972848607228e-308},
^
ERROR: spaces required around that '-' (ctx:VxV)
#3565: FILE: tests/tcg/arm/fcvt.c:211:
+ {1.4914738736681624e-308},
^
WARNING: architecture specific defines should be avoided
#3599: FILE: tests/tcg/arm/fcvt.c:245:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3623: FILE: tests/tcg/arm/fcvt.c:269:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3646: FILE: tests/tcg/arm/fcvt.c:292:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3690: FILE: tests/tcg/arm/fcvt.c:336:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3713: FILE: tests/tcg/arm/fcvt.c:359:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3735: FILE: tests/tcg/arm/fcvt.c:381:
+#if defined(__arm__)
WARNING: architecture specific defines should be avoided
#3780: FILE: tests/tcg/arm/fcvt.c:426:
+#if defined(__arm__)
ERROR: space prohibited before open square bracket '['
#3785: FILE: tests/tcg/arm/fcvt.c:431:
+ : /* no output */ : [flags] "n" (1 << 26) : "r1" );
ERROR: space prohibited before that close parenthesis ')'
#3785: FILE: tests/tcg/arm/fcvt.c:431:
+ : /* no output */ : [flags] "n" (1 << 26) : "r1" );
ERROR: space prohibited before open square bracket '['
#3790: FILE: tests/tcg/arm/fcvt.c:436:
+ : /* no output */ : [flags] "n" (1 << 26) : "x1" );
ERROR: space prohibited before that close parenthesis ')'
#3790: FILE: tests/tcg/arm/fcvt.c:436:
+ : /* no output */ : [flags] "n" (1 << 26) : "x1" );
total: 25 errors, 12 warnings, 7039 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 26/49: tests/tcg: move MIPS specific tests into subdir...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
total: 0 errors, 1 warnings, 24 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/49: tests/tcg: enable building for MIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 17 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 28/49: tests/tcg/mips: include common mips hello-mips...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
total: 0 errors, 1 warnings, 19 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 29/49: tests/tcg: enable building for s390x...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 2 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 30/49: tests/tcg: enable building for ppc64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 2 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 31/49: tests/tcg: enable building for Alpha...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 65 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 32/49: tests/tcg/alpha: add Alpha specific tests...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
deleted file mode 100644
total: 0 errors, 1 warnings, 31 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 33/49: tests/tcg: enable building for HPPA...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28:
new file mode 100644
total: 0 errors, 1 warnings, 27 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 34/49: tests/tcg: enable building for m68k...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
total: 0 errors, 1 warnings, 28 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 35/49: tests/tcg: enable building for sh4...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 30 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 36/49: tests/tcg: enable building for sparc64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 27 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 37/49: tests/tcg: enable building for mips64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 28 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 38/49: tests/tcg: enable building for RISCV64...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 29 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 39/49: docker: move debian-powerpc-cross to sid based build...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
deleted file mode 100755
total: 0 errors, 1 warnings, 71 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 40/49: tests/tcg: enable building for PowerPC...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 19 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 41/49: tests/tcg/Makefile: update to be called from Makefile.target...
Checking PATCH 42/49: Makefile.target: add (clean-/build-)guest-tests targets...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48:
new file mode 100644
total: 0 errors, 1 warnings, 106 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 43/49: tests/Makefile.include: add [build|clean|check]-tcg targets...
Checking PATCH 44/49: tests/tcg: add run, diff, and skip helper macros...
Checking PATCH 45/49: tests/tcg: override runners for broken tests...
Checking PATCH 46/49: target/sh4: Fix translator.c assertion failure for gUSA...
Checking PATCH 47/49: tests: add top-level make dependency for docker builds...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52:
new file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 48/49: tests/docker: prevent sub-makes re-building debian-sid...
Checking PATCH 49/49: .travis.yml: add check-tcg test...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 06/08/2018 09:32 AM, Alex Bennée wrote: > Hi, > > Not a super amount has changed since the last version but review > comments and review tags have been added. The new patches at the end > enable a .travis.yml run and try and make the image building part of > check-tcg -j safe. Essentially the problem is trying to avoid > re-building the images multiple times. The additional issue is wanting > an upto date Debian SID image whenever we actually build an image but > not forcing a rebuild every time. > > Essentially I'd like to encode a conditional dependency when: > - the target image doesn't exist > - or the target image is out of date w.r.t. the dockerfike > > I'm thinking this is going to involve some sort of extension to the > docker.py script to feed the Makefile. > > A number of the prerequisite patches have already been pulled in the > docker fixes series however I think this series is ready to go in now. > Unless there are any objections I'll send a pull on Monday. > > Current unreviewed patches: > > patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review > patch 0039/docker move debian powerpc cross to sid based bui.patch needs review > patch 0040/tests tcg enable building for PowerPC.patch needs review > patch 0042/Makefile.target add clean build guest tests targe.patch needs review > patch 0044/tests tcg add run diff and skip helper macros.patch needs review > patch 0045/tests tcg override runners for broken tests.patch needs review > patch 0046/target sh4 Fix translator.c assertion failure for.patch needs review Is this patch related/required to this series? It looks it should enter via another tree. The SH4 tests pass without it: $ make run-tcg-tests-sh4-linux-user -j1 ... RUN-TESTS for sh4 TEST test-mmap (default) on sh4 TEST sha1 on sh4 TEST linux-test on sh4 TEST testthread on sh4 TEST test-mmap (4096 byte pages) on sh4 > patch 0047/tests add top level make dependency for docker bu.patch needs review > patch 0048/tests docker prevent sub makes re building debian.patch needs review > patch 0049/.travis.yml add check tcg test.patch needs review > > > Alex Bennée (46): > configure: add support for --cross-cc-FOO > configure: move i386_cc to cross_cc_i386 > configure: allow user to specify --cross-cc-cflags-foo= > configure: set cross_cc_FOO for host compiler > docker: Add "cc" subcommand > docker: extend "cc" command to accept compiler > docker: allow "cc" command to run in user context > docker: Makefile.include introduce DOCKER_SCRIPT > tests/tcg: move architecture independent tests into subdir > tests/tcg/multiarch: enable additional linux-test tests > tests/tcg/multiarch: move most output to stdout > tests/tcg: move i386 specific tests into subdir > tests/tcg: enable building for i386 > tests/tcg/i386: fix test-i386 > tests/tcg/i386: add runner for test-i386-fprem > tests/tcg/x86_64: add Makefile.target > tests/tcg/i386/test-i386: use modern vector_size attributes > tests/tcg/i386/test-i386: fix printf format > tests/tcg: move ARM specific tests into subdir > tests/tcg: enable building for ARM > tests/tcg/arm: fix up test-arm-iwmmxt test > tests/tcg: enable building for AArch64 > tests/tcg/arm: add fcvt test cases for AArch32/64 > tests/tcg: move MIPS specific tests into subdir > tests/tcg: enable building for MIPS > tests/tcg/mips: include common mips hello-mips > tests/tcg: enable building for s390x > tests/tcg: enable building for ppc64 > tests/tcg: enable building for Alpha > tests/tcg/alpha: add Alpha specific tests > tests/tcg: enable building for HPPA > tests/tcg: enable building for m68k > tests/tcg: enable building for sh4 > tests/tcg: enable building for sparc64 > tests/tcg: enable building for mips64 > tests/tcg: enable building for RISCV64 > docker: move debian-powerpc-cross to sid based build > tests/tcg: enable building for PowerPC > tests/tcg/Makefile: update to be called from Makefile.target > Makefile.target: add (clean-/build-)guest-tests targets > tests/Makefile.include: add [build|clean|check]-tcg targets > tests/tcg: add run, diff, and skip helper macros > tests/tcg: override runners for broken tests > tests: add top-level make dependency for docker builds > tests/docker: prevent sub-makes re-building debian-sid > .travis.yml: add check-tcg test > > Fam Zheng (2): > tests/tcg/multiarch: Build fix for linux-test > tests/tcg/i386: Build fix for hello-i386 > > Richard Henderson (1): > target/sh4: Fix translator.c assertion failure for gUSA > > .travis.yml | 6 + > MAINTAINERS | 14 + > Makefile.target | 5 + > configure | 134 +- > target/sh4/translate.c | 81 +- > tests/Makefile.include | 38 +- > tests/docker/Makefile.include | 31 +- > tests/docker/docker.py | 31 + > .../dockerfiles/debian-alpha-cross.docker | 12 + > tests/docker/dockerfiles/debian-apt-fake.sh | 46 - > .../dockerfiles/debian-hppa-cross.docker | 12 + > .../dockerfiles/debian-m68k-cross.docker | 12 + > .../dockerfiles/debian-mips64-cross.docker | 12 + > .../dockerfiles/debian-powerpc-cross.docker | 39 +- > .../dockerfiles/debian-riscv64-cross.docker | 12 + > .../dockerfiles/debian-sh4-cross.docker | 12 + > tests/docker/dockerfiles/debian-sid.docker | 32 + > .../dockerfiles/debian-sparc64-cross.docker | 12 + > tests/docker/dockerfiles/debian8.docker | 3 - > tests/tcg/Makefile | 219 +- > tests/tcg/Makefile.include | 89 + > tests/tcg/Makefile.probe | 31 + > tests/tcg/README | 69 +- > tests/tcg/aarch64/Makefile.include | 8 + > tests/tcg/aarch64/Makefile.target | 17 + > tests/tcg/aarch64/fcvt.ref | 3268 +++++++++++++++++ > tests/tcg/alpha/Makefile | 35 - > tests/tcg/alpha/Makefile.include | 2 + > tests/tcg/alpha/Makefile.target | 18 + > tests/tcg/alpha/crt.s | 26 - > tests/tcg/alpha/hello-alpha.c | 2 + > tests/tcg/alpha/test-cond.c | 1 + > tests/tcg/alpha/test-ovf.c | 2 + > tests/tcg/arm/Makefile.include | 8 + > tests/tcg/arm/Makefile.target | 32 + > tests/tcg/arm/README | 11 + > tests/tcg/arm/fcvt.c | 458 +++ > tests/tcg/arm/fcvt.ref | 3268 +++++++++++++++++ > tests/tcg/{ => arm}/hello-arm.c | 0 > .../test-arm-iwmmxt.S} | 0 > tests/tcg/hppa/Makefile.include | 2 + > tests/tcg/hppa/Makefile.target | 6 + > tests/tcg/i386/Makefile.include | 9 + > tests/tcg/i386/Makefile.target | 51 + > tests/tcg/i386/README | 38 + > tests/tcg/{ => i386}/hello-i386.c | 1 + > tests/tcg/{ => i386}/pi_10.com | Bin > tests/tcg/{ => i386}/runcom.c | 0 > tests/tcg/{ => i386}/test-i386-code16.S | 0 > tests/tcg/{ => i386}/test-i386-fprem.c | 12 +- > tests/tcg/{ => i386}/test-i386-muldiv.h | 0 > tests/tcg/{ => i386}/test-i386-shift.h | 0 > tests/tcg/{ => i386}/test-i386-ssse3.c | 0 > tests/tcg/{ => i386}/test-i386-vm86.S | 0 > tests/tcg/{ => i386}/test-i386.c | 7 +- > tests/tcg/{ => i386}/test-i386.h | 0 > tests/tcg/m68k/Makefile.include | 2 + > tests/tcg/m68k/Makefile.target | 7 + > tests/tcg/mips/Makefile.include | 20 + > tests/tcg/mips/Makefile.target | 22 + > tests/tcg/mips/README | 7 + > tests/tcg/{ => mips}/hello-mips.c | 0 > tests/tcg/multiarch/Makefile.target | 36 + > tests/tcg/multiarch/README | 1 + > tests/tcg/{ => multiarch}/linux-test.c | 113 +- > tests/tcg/{ => multiarch}/sha1.c | 0 > tests/tcg/{ => multiarch}/test-mmap.c | 40 +- > tests/tcg/{ => multiarch}/testthread.c | 0 > tests/tcg/ppc/Makefile.include | 7 + > tests/tcg/ppc/Makefile.target | 12 + > tests/tcg/riscv/Makefile.include | 10 + > tests/tcg/s390x/Makefile.include | 2 + > tests/tcg/sh4/Makefile.include | 4 + > tests/tcg/sh4/Makefile.target | 7 + > tests/tcg/sparc64/Makefile.include | 2 + > tests/tcg/sparc64/Makefile.target | 11 + > tests/tcg/test_path.c | 157 - > tests/tcg/x86_64/Makefile.target | 15 + > 78 files changed, 8068 insertions(+), 641 deletions(-) > create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker > delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh > create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-sid.docker > create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker > create mode 100644 tests/tcg/Makefile.include > create mode 100644 tests/tcg/Makefile.probe > create mode 100644 tests/tcg/aarch64/Makefile.include > create mode 100644 tests/tcg/aarch64/Makefile.target > create mode 100644 tests/tcg/aarch64/fcvt.ref > delete mode 100644 tests/tcg/alpha/Makefile > create mode 100644 tests/tcg/alpha/Makefile.include > create mode 100644 tests/tcg/alpha/Makefile.target > delete mode 100644 tests/tcg/alpha/crt.s > create mode 100644 tests/tcg/arm/Makefile.include > create mode 100644 tests/tcg/arm/Makefile.target > create mode 100644 tests/tcg/arm/README > create mode 100644 tests/tcg/arm/fcvt.c > create mode 100644 tests/tcg/arm/fcvt.ref > rename tests/tcg/{ => arm}/hello-arm.c (100%) > rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%) > create mode 100644 tests/tcg/hppa/Makefile.include > create mode 100644 tests/tcg/hppa/Makefile.target > create mode 100644 tests/tcg/i386/Makefile.include > create mode 100644 tests/tcg/i386/Makefile.target > create mode 100644 tests/tcg/i386/README > rename tests/tcg/{ => i386}/hello-i386.c (96%) > rename tests/tcg/{ => i386}/pi_10.com (100%) > rename tests/tcg/{ => i386}/runcom.c (100%) > rename tests/tcg/{ => i386}/test-i386-code16.S (100%) > rename tests/tcg/{ => i386}/test-i386-fprem.c (97%) > rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%) > rename tests/tcg/{ => i386}/test-i386-shift.h (100%) > rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%) > rename tests/tcg/{ => i386}/test-i386-vm86.S (100%) > rename tests/tcg/{ => i386}/test-i386.c (99%) > rename tests/tcg/{ => i386}/test-i386.h (100%) > create mode 100644 tests/tcg/m68k/Makefile.include > create mode 100644 tests/tcg/m68k/Makefile.target > create mode 100644 tests/tcg/mips/Makefile.include > create mode 100644 tests/tcg/mips/Makefile.target > create mode 100644 tests/tcg/mips/README > rename tests/tcg/{ => mips}/hello-mips.c (100%) > create mode 100644 tests/tcg/multiarch/Makefile.target > create mode 100644 tests/tcg/multiarch/README > rename tests/tcg/{ => multiarch}/linux-test.c (86%) > rename tests/tcg/{ => multiarch}/sha1.c (100%) > rename tests/tcg/{ => multiarch}/test-mmap.c (93%) > rename tests/tcg/{ => multiarch}/testthread.c (100%) > create mode 100644 tests/tcg/ppc/Makefile.include > create mode 100644 tests/tcg/ppc/Makefile.target > create mode 100644 tests/tcg/riscv/Makefile.include > create mode 100644 tests/tcg/s390x/Makefile.include > create mode 100644 tests/tcg/sh4/Makefile.include > create mode 100644 tests/tcg/sh4/Makefile.target > create mode 100644 tests/tcg/sparc64/Makefile.include > create mode 100644 tests/tcg/sparc64/Makefile.target > delete mode 100644 tests/tcg/test_path.c > create mode 100644 tests/tcg/x86_64/Makefile.target >
Hi Alex, On 06/08/2018 09:32 AM, Alex Bennée wrote: > Hi, > > Not a super amount has changed since the last version but review > comments and review tags have been added. The new patches at the end > enable a .travis.yml run and try and make the image building part of > check-tcg -j safe. Essentially the problem is trying to avoid > re-building the images multiple times. The additional issue is wanting > an upto date Debian SID image whenever we actually build an image but > not forcing a rebuild every time. > > Essentially I'd like to encode a conditional dependency when: > - the target image doesn't exist > - or the target image is out of date w.r.t. the dockerfike > > I'm thinking this is going to involve some sort of extension to the > docker.py script to feed the Makefile. > > A number of the prerequisite patches have already been pulled in the > docker fixes series however I think this series is ready to go in now. > Unless there are any objections I'll send a pull on Monday. > > Current unreviewed patches: > > patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review > patch 0039/docker move debian powerpc cross to sid based bui.patch needs review > patch 0040/tests tcg enable building for PowerPC.patch needs review > patch 0042/Makefile.target add clean build guest tests targe.patch needs review > patch 0044/tests tcg add run diff and skip helper macros.patch needs review > patch 0045/tests tcg override runners for broken tests.patch needs review No problem until here. > patch 0046/target sh4 Fix translator.c assertion failure for.patch needs review Probably unrelated. > patch 0047/tests add top level make dependency for docker bu.patch needs review I think you could add patch #47 (which is the last piece required to test your work) removing the 'build-docker-prereqs' rule, and fix it during the week. > patch 0048/tests docker prevent sub makes re building debian.patch needs review I wouldn't include this one (yet). > patch 0049/.travis.yml add check tcg test.patch needs review You can include this one fixed using "-j1". Good work! :) Regards, Phil. > > > Alex Bennée (46): > configure: add support for --cross-cc-FOO > configure: move i386_cc to cross_cc_i386 > configure: allow user to specify --cross-cc-cflags-foo= > configure: set cross_cc_FOO for host compiler > docker: Add "cc" subcommand > docker: extend "cc" command to accept compiler > docker: allow "cc" command to run in user context > docker: Makefile.include introduce DOCKER_SCRIPT > tests/tcg: move architecture independent tests into subdir > tests/tcg/multiarch: enable additional linux-test tests > tests/tcg/multiarch: move most output to stdout > tests/tcg: move i386 specific tests into subdir > tests/tcg: enable building for i386 > tests/tcg/i386: fix test-i386 > tests/tcg/i386: add runner for test-i386-fprem > tests/tcg/x86_64: add Makefile.target > tests/tcg/i386/test-i386: use modern vector_size attributes > tests/tcg/i386/test-i386: fix printf format > tests/tcg: move ARM specific tests into subdir > tests/tcg: enable building for ARM > tests/tcg/arm: fix up test-arm-iwmmxt test > tests/tcg: enable building for AArch64 > tests/tcg/arm: add fcvt test cases for AArch32/64 > tests/tcg: move MIPS specific tests into subdir > tests/tcg: enable building for MIPS > tests/tcg/mips: include common mips hello-mips > tests/tcg: enable building for s390x > tests/tcg: enable building for ppc64 > tests/tcg: enable building for Alpha > tests/tcg/alpha: add Alpha specific tests > tests/tcg: enable building for HPPA > tests/tcg: enable building for m68k > tests/tcg: enable building for sh4 > tests/tcg: enable building for sparc64 > tests/tcg: enable building for mips64 > tests/tcg: enable building for RISCV64 > docker: move debian-powerpc-cross to sid based build > tests/tcg: enable building for PowerPC > tests/tcg/Makefile: update to be called from Makefile.target > Makefile.target: add (clean-/build-)guest-tests targets > tests/Makefile.include: add [build|clean|check]-tcg targets > tests/tcg: add run, diff, and skip helper macros > tests/tcg: override runners for broken tests > tests: add top-level make dependency for docker builds > tests/docker: prevent sub-makes re-building debian-sid > .travis.yml: add check-tcg test > > Fam Zheng (2): > tests/tcg/multiarch: Build fix for linux-test > tests/tcg/i386: Build fix for hello-i386 > > Richard Henderson (1): > target/sh4: Fix translator.c assertion failure for gUSA > > .travis.yml | 6 + > MAINTAINERS | 14 + > Makefile.target | 5 + > configure | 134 +- > target/sh4/translate.c | 81 +- > tests/Makefile.include | 38 +- > tests/docker/Makefile.include | 31 +- > tests/docker/docker.py | 31 + > .../dockerfiles/debian-alpha-cross.docker | 12 + > tests/docker/dockerfiles/debian-apt-fake.sh | 46 - > .../dockerfiles/debian-hppa-cross.docker | 12 + > .../dockerfiles/debian-m68k-cross.docker | 12 + > .../dockerfiles/debian-mips64-cross.docker | 12 + > .../dockerfiles/debian-powerpc-cross.docker | 39 +- > .../dockerfiles/debian-riscv64-cross.docker | 12 + > .../dockerfiles/debian-sh4-cross.docker | 12 + > tests/docker/dockerfiles/debian-sid.docker | 32 + > .../dockerfiles/debian-sparc64-cross.docker | 12 + > tests/docker/dockerfiles/debian8.docker | 3 - > tests/tcg/Makefile | 219 +- > tests/tcg/Makefile.include | 89 + > tests/tcg/Makefile.probe | 31 + > tests/tcg/README | 69 +- > tests/tcg/aarch64/Makefile.include | 8 + > tests/tcg/aarch64/Makefile.target | 17 + > tests/tcg/aarch64/fcvt.ref | 3268 +++++++++++++++++ > tests/tcg/alpha/Makefile | 35 - > tests/tcg/alpha/Makefile.include | 2 + > tests/tcg/alpha/Makefile.target | 18 + > tests/tcg/alpha/crt.s | 26 - > tests/tcg/alpha/hello-alpha.c | 2 + > tests/tcg/alpha/test-cond.c | 1 + > tests/tcg/alpha/test-ovf.c | 2 + > tests/tcg/arm/Makefile.include | 8 + > tests/tcg/arm/Makefile.target | 32 + > tests/tcg/arm/README | 11 + > tests/tcg/arm/fcvt.c | 458 +++ > tests/tcg/arm/fcvt.ref | 3268 +++++++++++++++++ > tests/tcg/{ => arm}/hello-arm.c | 0 > .../test-arm-iwmmxt.S} | 0 > tests/tcg/hppa/Makefile.include | 2 + > tests/tcg/hppa/Makefile.target | 6 + > tests/tcg/i386/Makefile.include | 9 + > tests/tcg/i386/Makefile.target | 51 + > tests/tcg/i386/README | 38 + > tests/tcg/{ => i386}/hello-i386.c | 1 + > tests/tcg/{ => i386}/pi_10.com | Bin > tests/tcg/{ => i386}/runcom.c | 0 > tests/tcg/{ => i386}/test-i386-code16.S | 0 > tests/tcg/{ => i386}/test-i386-fprem.c | 12 +- > tests/tcg/{ => i386}/test-i386-muldiv.h | 0 > tests/tcg/{ => i386}/test-i386-shift.h | 0 > tests/tcg/{ => i386}/test-i386-ssse3.c | 0 > tests/tcg/{ => i386}/test-i386-vm86.S | 0 > tests/tcg/{ => i386}/test-i386.c | 7 +- > tests/tcg/{ => i386}/test-i386.h | 0 > tests/tcg/m68k/Makefile.include | 2 + > tests/tcg/m68k/Makefile.target | 7 + > tests/tcg/mips/Makefile.include | 20 + > tests/tcg/mips/Makefile.target | 22 + > tests/tcg/mips/README | 7 + > tests/tcg/{ => mips}/hello-mips.c | 0 > tests/tcg/multiarch/Makefile.target | 36 + > tests/tcg/multiarch/README | 1 + > tests/tcg/{ => multiarch}/linux-test.c | 113 +- > tests/tcg/{ => multiarch}/sha1.c | 0 > tests/tcg/{ => multiarch}/test-mmap.c | 40 +- > tests/tcg/{ => multiarch}/testthread.c | 0 > tests/tcg/ppc/Makefile.include | 7 + > tests/tcg/ppc/Makefile.target | 12 + > tests/tcg/riscv/Makefile.include | 10 + > tests/tcg/s390x/Makefile.include | 2 + > tests/tcg/sh4/Makefile.include | 4 + > tests/tcg/sh4/Makefile.target | 7 + > tests/tcg/sparc64/Makefile.include | 2 + > tests/tcg/sparc64/Makefile.target | 11 + > tests/tcg/test_path.c | 157 - > tests/tcg/x86_64/Makefile.target | 15 + > 78 files changed, 8068 insertions(+), 641 deletions(-) > create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker > delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh > create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker > create mode 100644 tests/docker/dockerfiles/debian-sid.docker > create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker > create mode 100644 tests/tcg/Makefile.include > create mode 100644 tests/tcg/Makefile.probe > create mode 100644 tests/tcg/aarch64/Makefile.include > create mode 100644 tests/tcg/aarch64/Makefile.target > create mode 100644 tests/tcg/aarch64/fcvt.ref > delete mode 100644 tests/tcg/alpha/Makefile > create mode 100644 tests/tcg/alpha/Makefile.include > create mode 100644 tests/tcg/alpha/Makefile.target > delete mode 100644 tests/tcg/alpha/crt.s > create mode 100644 tests/tcg/arm/Makefile.include > create mode 100644 tests/tcg/arm/Makefile.target > create mode 100644 tests/tcg/arm/README > create mode 100644 tests/tcg/arm/fcvt.c > create mode 100644 tests/tcg/arm/fcvt.ref > rename tests/tcg/{ => arm}/hello-arm.c (100%) > rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%) > create mode 100644 tests/tcg/hppa/Makefile.include > create mode 100644 tests/tcg/hppa/Makefile.target > create mode 100644 tests/tcg/i386/Makefile.include > create mode 100644 tests/tcg/i386/Makefile.target > create mode 100644 tests/tcg/i386/README > rename tests/tcg/{ => i386}/hello-i386.c (96%) > rename tests/tcg/{ => i386}/pi_10.com (100%) > rename tests/tcg/{ => i386}/runcom.c (100%) > rename tests/tcg/{ => i386}/test-i386-code16.S (100%) > rename tests/tcg/{ => i386}/test-i386-fprem.c (97%) > rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%) > rename tests/tcg/{ => i386}/test-i386-shift.h (100%) > rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%) > rename tests/tcg/{ => i386}/test-i386-vm86.S (100%) > rename tests/tcg/{ => i386}/test-i386.c (99%) > rename tests/tcg/{ => i386}/test-i386.h (100%) > create mode 100644 tests/tcg/m68k/Makefile.include > create mode 100644 tests/tcg/m68k/Makefile.target > create mode 100644 tests/tcg/mips/Makefile.include > create mode 100644 tests/tcg/mips/Makefile.target > create mode 100644 tests/tcg/mips/README > rename tests/tcg/{ => mips}/hello-mips.c (100%) > create mode 100644 tests/tcg/multiarch/Makefile.target > create mode 100644 tests/tcg/multiarch/README > rename tests/tcg/{ => multiarch}/linux-test.c (86%) > rename tests/tcg/{ => multiarch}/sha1.c (100%) > rename tests/tcg/{ => multiarch}/test-mmap.c (93%) > rename tests/tcg/{ => multiarch}/testthread.c (100%) > create mode 100644 tests/tcg/ppc/Makefile.include > create mode 100644 tests/tcg/ppc/Makefile.target > create mode 100644 tests/tcg/riscv/Makefile.include > create mode 100644 tests/tcg/s390x/Makefile.include > create mode 100644 tests/tcg/sh4/Makefile.include > create mode 100644 tests/tcg/sh4/Makefile.target > create mode 100644 tests/tcg/sparc64/Makefile.include > create mode 100644 tests/tcg/sparc64/Makefile.target > delete mode 100644 tests/tcg/test_path.c > create mode 100644 tests/tcg/x86_64/Makefile.target >
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > On 06/08/2018 09:32 AM, Alex Bennée wrote: >> Hi, >> >> Not a super amount has changed since the last version but review >> comments and review tags have been added. The new patches at the end >> enable a .travis.yml run and try and make the image building part of >> check-tcg -j safe. Essentially the problem is trying to avoid >> re-building the images multiple times. The additional issue is wanting >> an upto date Debian SID image whenever we actually build an image but >> not forcing a rebuild every time. >> >> Essentially I'd like to encode a conditional dependency when: >> - the target image doesn't exist >> - or the target image is out of date w.r.t. the dockerfike >> >> I'm thinking this is going to involve some sort of extension to the >> docker.py script to feed the Makefile. >> >> A number of the prerequisite patches have already been pulled in the >> docker fixes series however I think this series is ready to go in now. >> Unless there are any objections I'll send a pull on Monday. >> >> Current unreviewed patches: >> >> patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review >> patch 0039/docker move debian powerpc cross to sid based bui.patch needs review >> patch 0040/tests tcg enable building for PowerPC.patch needs review >> patch 0042/Makefile.target add clean build guest tests targe.patch needs review >> patch 0044/tests tcg add run diff and skip helper macros.patch needs review >> patch 0045/tests tcg override runners for broken tests.patch needs review >> patch 0046/target sh4 Fix translator.c assertion failure for.patch needs review > > Is this patch related/required to this series? > It looks it should enter via another tree. > > The SH4 tests pass without it: > > $ make run-tcg-tests-sh4-linux-user -j1 > ... > RUN-TESTS for sh4 > TEST test-mmap (default) on sh4 > TEST sha1 on sh4 > TEST linux-test on sh4 > TEST testthread on sh4 > TEST test-mmap (4096 byte pages) on sh4 Not with --enable-debug, but yeah I'll drop as it should come via Rich's TCG tree. > >> patch 0047/tests add top level make dependency for docker bu.patch needs review >> patch 0048/tests docker prevent sub makes re building debian.patch needs review >> patch 0049/.travis.yml add check tcg test.patch needs review >> >> >> Alex Bennée (46): >> configure: add support for --cross-cc-FOO >> configure: move i386_cc to cross_cc_i386 >> configure: allow user to specify --cross-cc-cflags-foo= >> configure: set cross_cc_FOO for host compiler >> docker: Add "cc" subcommand >> docker: extend "cc" command to accept compiler >> docker: allow "cc" command to run in user context >> docker: Makefile.include introduce DOCKER_SCRIPT >> tests/tcg: move architecture independent tests into subdir >> tests/tcg/multiarch: enable additional linux-test tests >> tests/tcg/multiarch: move most output to stdout >> tests/tcg: move i386 specific tests into subdir >> tests/tcg: enable building for i386 >> tests/tcg/i386: fix test-i386 >> tests/tcg/i386: add runner for test-i386-fprem >> tests/tcg/x86_64: add Makefile.target >> tests/tcg/i386/test-i386: use modern vector_size attributes >> tests/tcg/i386/test-i386: fix printf format >> tests/tcg: move ARM specific tests into subdir >> tests/tcg: enable building for ARM >> tests/tcg/arm: fix up test-arm-iwmmxt test >> tests/tcg: enable building for AArch64 >> tests/tcg/arm: add fcvt test cases for AArch32/64 >> tests/tcg: move MIPS specific tests into subdir >> tests/tcg: enable building for MIPS >> tests/tcg/mips: include common mips hello-mips >> tests/tcg: enable building for s390x >> tests/tcg: enable building for ppc64 >> tests/tcg: enable building for Alpha >> tests/tcg/alpha: add Alpha specific tests >> tests/tcg: enable building for HPPA >> tests/tcg: enable building for m68k >> tests/tcg: enable building for sh4 >> tests/tcg: enable building for sparc64 >> tests/tcg: enable building for mips64 >> tests/tcg: enable building for RISCV64 >> docker: move debian-powerpc-cross to sid based build >> tests/tcg: enable building for PowerPC >> tests/tcg/Makefile: update to be called from Makefile.target >> Makefile.target: add (clean-/build-)guest-tests targets >> tests/Makefile.include: add [build|clean|check]-tcg targets >> tests/tcg: add run, diff, and skip helper macros >> tests/tcg: override runners for broken tests >> tests: add top-level make dependency for docker builds >> tests/docker: prevent sub-makes re-building debian-sid >> .travis.yml: add check-tcg test >> >> Fam Zheng (2): >> tests/tcg/multiarch: Build fix for linux-test >> tests/tcg/i386: Build fix for hello-i386 >> >> Richard Henderson (1): >> target/sh4: Fix translator.c assertion failure for gUSA >> >> .travis.yml | 6 + >> MAINTAINERS | 14 + >> Makefile.target | 5 + >> configure | 134 +- >> target/sh4/translate.c | 81 +- >> tests/Makefile.include | 38 +- >> tests/docker/Makefile.include | 31 +- >> tests/docker/docker.py | 31 + >> .../dockerfiles/debian-alpha-cross.docker | 12 + >> tests/docker/dockerfiles/debian-apt-fake.sh | 46 - >> .../dockerfiles/debian-hppa-cross.docker | 12 + >> .../dockerfiles/debian-m68k-cross.docker | 12 + >> .../dockerfiles/debian-mips64-cross.docker | 12 + >> .../dockerfiles/debian-powerpc-cross.docker | 39 +- >> .../dockerfiles/debian-riscv64-cross.docker | 12 + >> .../dockerfiles/debian-sh4-cross.docker | 12 + >> tests/docker/dockerfiles/debian-sid.docker | 32 + >> .../dockerfiles/debian-sparc64-cross.docker | 12 + >> tests/docker/dockerfiles/debian8.docker | 3 - >> tests/tcg/Makefile | 219 +- >> tests/tcg/Makefile.include | 89 + >> tests/tcg/Makefile.probe | 31 + >> tests/tcg/README | 69 +- >> tests/tcg/aarch64/Makefile.include | 8 + >> tests/tcg/aarch64/Makefile.target | 17 + >> tests/tcg/aarch64/fcvt.ref | 3268 +++++++++++++++++ >> tests/tcg/alpha/Makefile | 35 - >> tests/tcg/alpha/Makefile.include | 2 + >> tests/tcg/alpha/Makefile.target | 18 + >> tests/tcg/alpha/crt.s | 26 - >> tests/tcg/alpha/hello-alpha.c | 2 + >> tests/tcg/alpha/test-cond.c | 1 + >> tests/tcg/alpha/test-ovf.c | 2 + >> tests/tcg/arm/Makefile.include | 8 + >> tests/tcg/arm/Makefile.target | 32 + >> tests/tcg/arm/README | 11 + >> tests/tcg/arm/fcvt.c | 458 +++ >> tests/tcg/arm/fcvt.ref | 3268 +++++++++++++++++ >> tests/tcg/{ => arm}/hello-arm.c | 0 >> .../test-arm-iwmmxt.S} | 0 >> tests/tcg/hppa/Makefile.include | 2 + >> tests/tcg/hppa/Makefile.target | 6 + >> tests/tcg/i386/Makefile.include | 9 + >> tests/tcg/i386/Makefile.target | 51 + >> tests/tcg/i386/README | 38 + >> tests/tcg/{ => i386}/hello-i386.c | 1 + >> tests/tcg/{ => i386}/pi_10.com | Bin >> tests/tcg/{ => i386}/runcom.c | 0 >> tests/tcg/{ => i386}/test-i386-code16.S | 0 >> tests/tcg/{ => i386}/test-i386-fprem.c | 12 +- >> tests/tcg/{ => i386}/test-i386-muldiv.h | 0 >> tests/tcg/{ => i386}/test-i386-shift.h | 0 >> tests/tcg/{ => i386}/test-i386-ssse3.c | 0 >> tests/tcg/{ => i386}/test-i386-vm86.S | 0 >> tests/tcg/{ => i386}/test-i386.c | 7 +- >> tests/tcg/{ => i386}/test-i386.h | 0 >> tests/tcg/m68k/Makefile.include | 2 + >> tests/tcg/m68k/Makefile.target | 7 + >> tests/tcg/mips/Makefile.include | 20 + >> tests/tcg/mips/Makefile.target | 22 + >> tests/tcg/mips/README | 7 + >> tests/tcg/{ => mips}/hello-mips.c | 0 >> tests/tcg/multiarch/Makefile.target | 36 + >> tests/tcg/multiarch/README | 1 + >> tests/tcg/{ => multiarch}/linux-test.c | 113 +- >> tests/tcg/{ => multiarch}/sha1.c | 0 >> tests/tcg/{ => multiarch}/test-mmap.c | 40 +- >> tests/tcg/{ => multiarch}/testthread.c | 0 >> tests/tcg/ppc/Makefile.include | 7 + >> tests/tcg/ppc/Makefile.target | 12 + >> tests/tcg/riscv/Makefile.include | 10 + >> tests/tcg/s390x/Makefile.include | 2 + >> tests/tcg/sh4/Makefile.include | 4 + >> tests/tcg/sh4/Makefile.target | 7 + >> tests/tcg/sparc64/Makefile.include | 2 + >> tests/tcg/sparc64/Makefile.target | 11 + >> tests/tcg/test_path.c | 157 - >> tests/tcg/x86_64/Makefile.target | 15 + >> 78 files changed, 8068 insertions(+), 641 deletions(-) >> create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker >> delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh >> create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker >> create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker >> create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker >> create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker >> create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker >> create mode 100644 tests/docker/dockerfiles/debian-sid.docker >> create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker >> create mode 100644 tests/tcg/Makefile.include >> create mode 100644 tests/tcg/Makefile.probe >> create mode 100644 tests/tcg/aarch64/Makefile.include >> create mode 100644 tests/tcg/aarch64/Makefile.target >> create mode 100644 tests/tcg/aarch64/fcvt.ref >> delete mode 100644 tests/tcg/alpha/Makefile >> create mode 100644 tests/tcg/alpha/Makefile.include >> create mode 100644 tests/tcg/alpha/Makefile.target >> delete mode 100644 tests/tcg/alpha/crt.s >> create mode 100644 tests/tcg/arm/Makefile.include >> create mode 100644 tests/tcg/arm/Makefile.target >> create mode 100644 tests/tcg/arm/README >> create mode 100644 tests/tcg/arm/fcvt.c >> create mode 100644 tests/tcg/arm/fcvt.ref >> rename tests/tcg/{ => arm}/hello-arm.c (100%) >> rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%) >> create mode 100644 tests/tcg/hppa/Makefile.include >> create mode 100644 tests/tcg/hppa/Makefile.target >> create mode 100644 tests/tcg/i386/Makefile.include >> create mode 100644 tests/tcg/i386/Makefile.target >> create mode 100644 tests/tcg/i386/README >> rename tests/tcg/{ => i386}/hello-i386.c (96%) >> rename tests/tcg/{ => i386}/pi_10.com (100%) >> rename tests/tcg/{ => i386}/runcom.c (100%) >> rename tests/tcg/{ => i386}/test-i386-code16.S (100%) >> rename tests/tcg/{ => i386}/test-i386-fprem.c (97%) >> rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%) >> rename tests/tcg/{ => i386}/test-i386-shift.h (100%) >> rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%) >> rename tests/tcg/{ => i386}/test-i386-vm86.S (100%) >> rename tests/tcg/{ => i386}/test-i386.c (99%) >> rename tests/tcg/{ => i386}/test-i386.h (100%) >> create mode 100644 tests/tcg/m68k/Makefile.include >> create mode 100644 tests/tcg/m68k/Makefile.target >> create mode 100644 tests/tcg/mips/Makefile.include >> create mode 100644 tests/tcg/mips/Makefile.target >> create mode 100644 tests/tcg/mips/README >> rename tests/tcg/{ => mips}/hello-mips.c (100%) >> create mode 100644 tests/tcg/multiarch/Makefile.target >> create mode 100644 tests/tcg/multiarch/README >> rename tests/tcg/{ => multiarch}/linux-test.c (86%) >> rename tests/tcg/{ => multiarch}/sha1.c (100%) >> rename tests/tcg/{ => multiarch}/test-mmap.c (93%) >> rename tests/tcg/{ => multiarch}/testthread.c (100%) >> create mode 100644 tests/tcg/ppc/Makefile.include >> create mode 100644 tests/tcg/ppc/Makefile.target >> create mode 100644 tests/tcg/riscv/Makefile.include >> create mode 100644 tests/tcg/s390x/Makefile.include >> create mode 100644 tests/tcg/sh4/Makefile.include >> create mode 100644 tests/tcg/sh4/Makefile.target >> create mode 100644 tests/tcg/sparc64/Makefile.include >> create mode 100644 tests/tcg/sparc64/Makefile.target >> delete mode 100644 tests/tcg/test_path.c >> create mode 100644 tests/tcg/x86_64/Makefile.target >> -- Alex Bennée
On 06/11/2018 05:19 AM, Alex Bennée wrote: > Philippe Mathieu-Daudé <f4bug@amsat.org> writes: >> On 06/08/2018 09:32 AM, Alex Bennée wrote: >>> Hi, >>> >>> Not a super amount has changed since the last version but review >>> comments and review tags have been added. The new patches at the end >>> enable a .travis.yml run and try and make the image building part of >>> check-tcg -j safe. Essentially the problem is trying to avoid >>> re-building the images multiple times. The additional issue is wanting >>> an upto date Debian SID image whenever we actually build an image but >>> not forcing a rebuild every time. >>> >>> Essentially I'd like to encode a conditional dependency when: >>> - the target image doesn't exist >>> - or the target image is out of date w.r.t. the dockerfike >>> >>> I'm thinking this is going to involve some sort of extension to the >>> docker.py script to feed the Makefile. >>> >>> A number of the prerequisite patches have already been pulled in the >>> docker fixes series however I think this series is ready to go in now. >>> Unless there are any objections I'll send a pull on Monday. >>> >>> Current unreviewed patches: >>> >>> patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review >>> patch 0039/docker move debian powerpc cross to sid based bui.patch needs review >>> patch 0040/tests tcg enable building for PowerPC.patch needs review >>> patch 0042/Makefile.target add clean build guest tests targe.patch needs review >>> patch 0044/tests tcg add run diff and skip helper macros.patch needs review >>> patch 0045/tests tcg override runners for broken tests.patch needs review >>> patch 0046/target sh4 Fix translator.c assertion failure for.patch needs review >> >> Is this patch related/required to this series? >> It looks it should enter via another tree. >> >> The SH4 tests pass without it: >> >> $ make run-tcg-tests-sh4-linux-user -j1 >> ... >> RUN-TESTS for sh4 >> TEST test-mmap (default) on sh4 >> TEST sha1 on sh4 >> TEST linux-test on sh4 >> TEST testthread on sh4 >> TEST test-mmap (4096 byte pages) on sh4 > > Not with --enable-debug, but yeah I'll drop as it should come via Rich's > TCG tree. Oh I just tested the basic options, didn't go with all the matrix :/ Indeed, RUN-TESTS for sh4 TEST test-mmap (default) on sh4 TEST sha1 on sh4 TEST linux-test on sh4 TEST testthread on sh4 qemu-sh4: accel/tcg/translator.c:66: translator_loop: Assertion `db->is_jmp == DISAS_NEXT' failed. qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault make: *** [tests/Makefile.include:950: run-tcg-tests-sh4-linux-user] Error 2 I'd still prefer this enter via Richard tree, and keep this PR testing-only (in case if bisection in translate.c, this might goes very slow due to your changes in ./configure triggering full rebuild). > >> >>> patch 0047/tests add top level make dependency for docker bu.patch needs review >>> patch 0048/tests docker prevent sub makes re building debian.patch needs review >>> patch 0049/.travis.yml add check tcg test.patch needs review >>> >>> >>> Alex Bennée (46): >>> configure: add support for --cross-cc-FOO >>> configure: move i386_cc to cross_cc_i386 >>> configure: allow user to specify --cross-cc-cflags-foo= >>> configure: set cross_cc_FOO for host compiler >>> docker: Add "cc" subcommand >>> docker: extend "cc" command to accept compiler >>> docker: allow "cc" command to run in user context >>> docker: Makefile.include introduce DOCKER_SCRIPT >>> tests/tcg: move architecture independent tests into subdir >>> tests/tcg/multiarch: enable additional linux-test tests >>> tests/tcg/multiarch: move most output to stdout >>> tests/tcg: move i386 specific tests into subdir >>> tests/tcg: enable building for i386 >>> tests/tcg/i386: fix test-i386 >>> tests/tcg/i386: add runner for test-i386-fprem >>> tests/tcg/x86_64: add Makefile.target >>> tests/tcg/i386/test-i386: use modern vector_size attributes >>> tests/tcg/i386/test-i386: fix printf format >>> tests/tcg: move ARM specific tests into subdir >>> tests/tcg: enable building for ARM >>> tests/tcg/arm: fix up test-arm-iwmmxt test >>> tests/tcg: enable building for AArch64 >>> tests/tcg/arm: add fcvt test cases for AArch32/64 >>> tests/tcg: move MIPS specific tests into subdir >>> tests/tcg: enable building for MIPS >>> tests/tcg/mips: include common mips hello-mips >>> tests/tcg: enable building for s390x >>> tests/tcg: enable building for ppc64 >>> tests/tcg: enable building for Alpha >>> tests/tcg/alpha: add Alpha specific tests >>> tests/tcg: enable building for HPPA >>> tests/tcg: enable building for m68k >>> tests/tcg: enable building for sh4 >>> tests/tcg: enable building for sparc64 >>> tests/tcg: enable building for mips64 >>> tests/tcg: enable building for RISCV64 >>> docker: move debian-powerpc-cross to sid based build >>> tests/tcg: enable building for PowerPC >>> tests/tcg/Makefile: update to be called from Makefile.target >>> Makefile.target: add (clean-/build-)guest-tests targets >>> tests/Makefile.include: add [build|clean|check]-tcg targets >>> tests/tcg: add run, diff, and skip helper macros >>> tests/tcg: override runners for broken tests >>> tests: add top-level make dependency for docker builds >>> tests/docker: prevent sub-makes re-building debian-sid >>> .travis.yml: add check-tcg test >>> >>> Fam Zheng (2): >>> tests/tcg/multiarch: Build fix for linux-test >>> tests/tcg/i386: Build fix for hello-i386 >>> >>> Richard Henderson (1): >>> target/sh4: Fix translator.c assertion failure for gUSA >>> >>> .travis.yml | 6 + >>> MAINTAINERS | 14 + >>> Makefile.target | 5 + >>> configure | 134 +- >>> target/sh4/translate.c | 81 +- >>> tests/Makefile.include | 38 +- >>> tests/docker/Makefile.include | 31 +- >>> tests/docker/docker.py | 31 + >>> .../dockerfiles/debian-alpha-cross.docker | 12 + >>> tests/docker/dockerfiles/debian-apt-fake.sh | 46 - >>> .../dockerfiles/debian-hppa-cross.docker | 12 + >>> .../dockerfiles/debian-m68k-cross.docker | 12 + >>> .../dockerfiles/debian-mips64-cross.docker | 12 + >>> .../dockerfiles/debian-powerpc-cross.docker | 39 +- >>> .../dockerfiles/debian-riscv64-cross.docker | 12 + >>> .../dockerfiles/debian-sh4-cross.docker | 12 + >>> tests/docker/dockerfiles/debian-sid.docker | 32 + >>> .../dockerfiles/debian-sparc64-cross.docker | 12 + >>> tests/docker/dockerfiles/debian8.docker | 3 - >>> tests/tcg/Makefile | 219 +- >>> tests/tcg/Makefile.include | 89 + >>> tests/tcg/Makefile.probe | 31 + >>> tests/tcg/README | 69 +- >>> tests/tcg/aarch64/Makefile.include | 8 + >>> tests/tcg/aarch64/Makefile.target | 17 + >>> tests/tcg/aarch64/fcvt.ref | 3268 +++++++++++++++++ >>> tests/tcg/alpha/Makefile | 35 - >>> tests/tcg/alpha/Makefile.include | 2 + >>> tests/tcg/alpha/Makefile.target | 18 + >>> tests/tcg/alpha/crt.s | 26 - >>> tests/tcg/alpha/hello-alpha.c | 2 + >>> tests/tcg/alpha/test-cond.c | 1 + >>> tests/tcg/alpha/test-ovf.c | 2 + >>> tests/tcg/arm/Makefile.include | 8 + >>> tests/tcg/arm/Makefile.target | 32 + >>> tests/tcg/arm/README | 11 + >>> tests/tcg/arm/fcvt.c | 458 +++ >>> tests/tcg/arm/fcvt.ref | 3268 +++++++++++++++++ >>> tests/tcg/{ => arm}/hello-arm.c | 0 >>> .../test-arm-iwmmxt.S} | 0 >>> tests/tcg/hppa/Makefile.include | 2 + >>> tests/tcg/hppa/Makefile.target | 6 + >>> tests/tcg/i386/Makefile.include | 9 + >>> tests/tcg/i386/Makefile.target | 51 + >>> tests/tcg/i386/README | 38 + >>> tests/tcg/{ => i386}/hello-i386.c | 1 + >>> tests/tcg/{ => i386}/pi_10.com | Bin >>> tests/tcg/{ => i386}/runcom.c | 0 >>> tests/tcg/{ => i386}/test-i386-code16.S | 0 >>> tests/tcg/{ => i386}/test-i386-fprem.c | 12 +- >>> tests/tcg/{ => i386}/test-i386-muldiv.h | 0 >>> tests/tcg/{ => i386}/test-i386-shift.h | 0 >>> tests/tcg/{ => i386}/test-i386-ssse3.c | 0 >>> tests/tcg/{ => i386}/test-i386-vm86.S | 0 >>> tests/tcg/{ => i386}/test-i386.c | 7 +- >>> tests/tcg/{ => i386}/test-i386.h | 0 >>> tests/tcg/m68k/Makefile.include | 2 + >>> tests/tcg/m68k/Makefile.target | 7 + >>> tests/tcg/mips/Makefile.include | 20 + >>> tests/tcg/mips/Makefile.target | 22 + >>> tests/tcg/mips/README | 7 + >>> tests/tcg/{ => mips}/hello-mips.c | 0 >>> tests/tcg/multiarch/Makefile.target | 36 + >>> tests/tcg/multiarch/README | 1 + >>> tests/tcg/{ => multiarch}/linux-test.c | 113 +- >>> tests/tcg/{ => multiarch}/sha1.c | 0 >>> tests/tcg/{ => multiarch}/test-mmap.c | 40 +- >>> tests/tcg/{ => multiarch}/testthread.c | 0 >>> tests/tcg/ppc/Makefile.include | 7 + >>> tests/tcg/ppc/Makefile.target | 12 + >>> tests/tcg/riscv/Makefile.include | 10 + >>> tests/tcg/s390x/Makefile.include | 2 + >>> tests/tcg/sh4/Makefile.include | 4 + >>> tests/tcg/sh4/Makefile.target | 7 + >>> tests/tcg/sparc64/Makefile.include | 2 + >>> tests/tcg/sparc64/Makefile.target | 11 + >>> tests/tcg/test_path.c | 157 - >>> tests/tcg/x86_64/Makefile.target | 15 + >>> 78 files changed, 8068 insertions(+), 641 deletions(-) >>> create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker >>> delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh >>> create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker >>> create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker >>> create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker >>> create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker >>> create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker >>> create mode 100644 tests/docker/dockerfiles/debian-sid.docker >>> create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker >>> create mode 100644 tests/tcg/Makefile.include >>> create mode 100644 tests/tcg/Makefile.probe >>> create mode 100644 tests/tcg/aarch64/Makefile.include >>> create mode 100644 tests/tcg/aarch64/Makefile.target >>> create mode 100644 tests/tcg/aarch64/fcvt.ref >>> delete mode 100644 tests/tcg/alpha/Makefile >>> create mode 100644 tests/tcg/alpha/Makefile.include >>> create mode 100644 tests/tcg/alpha/Makefile.target >>> delete mode 100644 tests/tcg/alpha/crt.s >>> create mode 100644 tests/tcg/arm/Makefile.include >>> create mode 100644 tests/tcg/arm/Makefile.target >>> create mode 100644 tests/tcg/arm/README >>> create mode 100644 tests/tcg/arm/fcvt.c >>> create mode 100644 tests/tcg/arm/fcvt.ref >>> rename tests/tcg/{ => arm}/hello-arm.c (100%) >>> rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%) >>> create mode 100644 tests/tcg/hppa/Makefile.include >>> create mode 100644 tests/tcg/hppa/Makefile.target >>> create mode 100644 tests/tcg/i386/Makefile.include >>> create mode 100644 tests/tcg/i386/Makefile.target >>> create mode 100644 tests/tcg/i386/README >>> rename tests/tcg/{ => i386}/hello-i386.c (96%) >>> rename tests/tcg/{ => i386}/pi_10.com (100%) >>> rename tests/tcg/{ => i386}/runcom.c (100%) >>> rename tests/tcg/{ => i386}/test-i386-code16.S (100%) >>> rename tests/tcg/{ => i386}/test-i386-fprem.c (97%) >>> rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%) >>> rename tests/tcg/{ => i386}/test-i386-shift.h (100%) >>> rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%) >>> rename tests/tcg/{ => i386}/test-i386-vm86.S (100%) >>> rename tests/tcg/{ => i386}/test-i386.c (99%) >>> rename tests/tcg/{ => i386}/test-i386.h (100%) >>> create mode 100644 tests/tcg/m68k/Makefile.include >>> create mode 100644 tests/tcg/m68k/Makefile.target >>> create mode 100644 tests/tcg/mips/Makefile.include >>> create mode 100644 tests/tcg/mips/Makefile.target >>> create mode 100644 tests/tcg/mips/README >>> rename tests/tcg/{ => mips}/hello-mips.c (100%) >>> create mode 100644 tests/tcg/multiarch/Makefile.target >>> create mode 100644 tests/tcg/multiarch/README >>> rename tests/tcg/{ => multiarch}/linux-test.c (86%) >>> rename tests/tcg/{ => multiarch}/sha1.c (100%) >>> rename tests/tcg/{ => multiarch}/test-mmap.c (93%) >>> rename tests/tcg/{ => multiarch}/testthread.c (100%) >>> create mode 100644 tests/tcg/ppc/Makefile.include >>> create mode 100644 tests/tcg/ppc/Makefile.target >>> create mode 100644 tests/tcg/riscv/Makefile.include >>> create mode 100644 tests/tcg/s390x/Makefile.include >>> create mode 100644 tests/tcg/sh4/Makefile.include >>> create mode 100644 tests/tcg/sh4/Makefile.target >>> create mode 100644 tests/tcg/sparc64/Makefile.include >>> create mode 100644 tests/tcg/sparc64/Makefile.target >>> delete mode 100644 tests/tcg/test_path.c >>> create mode 100644 tests/tcg/x86_64/Makefile.target >>> > > > -- > Alex Bennée >
Hi, Not a super amount has changed since the last version but review comments and review tags have been added. The new patches at the end enable a .travis.yml run and try and make the image building part of check-tcg -j safe. Essentially the problem is trying to avoid re-building the images multiple times. The additional issue is wanting an upto date Debian SID image whenever we actually build an image but not forcing a rebuild every time. Essentially I'd like to encode a conditional dependency when: - the target image doesn't exist - or the target image is out of date w.r.t. the dockerfike I'm thinking this is going to involve some sort of extension to the docker.py script to feed the Makefile. A number of the prerequisite patches have already been pulled in the docker fixes series however I think this series is ready to go in now. Unless there are any objections I'll send a pull on Monday. Current unreviewed patches: patch 0017/tests tcg i386 add runner for test i386 fprem.patch needs review patch 0039/docker move debian powerpc cross to sid based bui.patch needs review patch 0040/tests tcg enable building for PowerPC.patch needs review patch 0042/Makefile.target add clean build guest tests targe.patch needs review patch 0044/tests tcg add run diff and skip helper macros.patch needs review patch 0045/tests tcg override runners for broken tests.patch needs review patch 0046/target sh4 Fix translator.c assertion failure for.patch needs review patch 0047/tests add top level make dependency for docker bu.patch needs review patch 0048/tests docker prevent sub makes re building debian.patch needs review patch 0049/.travis.yml add check tcg test.patch needs review Alex Bennée (46): configure: add support for --cross-cc-FOO configure: move i386_cc to cross_cc_i386 configure: allow user to specify --cross-cc-cflags-foo= configure: set cross_cc_FOO for host compiler docker: Add "cc" subcommand docker: extend "cc" command to accept compiler docker: allow "cc" command to run in user context docker: Makefile.include introduce DOCKER_SCRIPT tests/tcg: move architecture independent tests into subdir tests/tcg/multiarch: enable additional linux-test tests tests/tcg/multiarch: move most output to stdout tests/tcg: move i386 specific tests into subdir tests/tcg: enable building for i386 tests/tcg/i386: fix test-i386 tests/tcg/i386: add runner for test-i386-fprem tests/tcg/x86_64: add Makefile.target tests/tcg/i386/test-i386: use modern vector_size attributes tests/tcg/i386/test-i386: fix printf format tests/tcg: move ARM specific tests into subdir tests/tcg: enable building for ARM tests/tcg/arm: fix up test-arm-iwmmxt test tests/tcg: enable building for AArch64 tests/tcg/arm: add fcvt test cases for AArch32/64 tests/tcg: move MIPS specific tests into subdir tests/tcg: enable building for MIPS tests/tcg/mips: include common mips hello-mips tests/tcg: enable building for s390x tests/tcg: enable building for ppc64 tests/tcg: enable building for Alpha tests/tcg/alpha: add Alpha specific tests tests/tcg: enable building for HPPA tests/tcg: enable building for m68k tests/tcg: enable building for sh4 tests/tcg: enable building for sparc64 tests/tcg: enable building for mips64 tests/tcg: enable building for RISCV64 docker: move debian-powerpc-cross to sid based build tests/tcg: enable building for PowerPC tests/tcg/Makefile: update to be called from Makefile.target Makefile.target: add (clean-/build-)guest-tests targets tests/Makefile.include: add [build|clean|check]-tcg targets tests/tcg: add run, diff, and skip helper macros tests/tcg: override runners for broken tests tests: add top-level make dependency for docker builds tests/docker: prevent sub-makes re-building debian-sid .travis.yml: add check-tcg test Fam Zheng (2): tests/tcg/multiarch: Build fix for linux-test tests/tcg/i386: Build fix for hello-i386 Richard Henderson (1): target/sh4: Fix translator.c assertion failure for gUSA .travis.yml | 6 + MAINTAINERS | 14 + Makefile.target | 5 + configure | 134 +- target/sh4/translate.c | 81 +- tests/Makefile.include | 38 +- tests/docker/Makefile.include | 31 +- tests/docker/docker.py | 31 + .../dockerfiles/debian-alpha-cross.docker | 12 + tests/docker/dockerfiles/debian-apt-fake.sh | 46 - .../dockerfiles/debian-hppa-cross.docker | 12 + .../dockerfiles/debian-m68k-cross.docker | 12 + .../dockerfiles/debian-mips64-cross.docker | 12 + .../dockerfiles/debian-powerpc-cross.docker | 39 +- .../dockerfiles/debian-riscv64-cross.docker | 12 + .../dockerfiles/debian-sh4-cross.docker | 12 + tests/docker/dockerfiles/debian-sid.docker | 32 + .../dockerfiles/debian-sparc64-cross.docker | 12 + tests/docker/dockerfiles/debian8.docker | 3 - tests/tcg/Makefile | 219 +- tests/tcg/Makefile.include | 89 + tests/tcg/Makefile.probe | 31 + tests/tcg/README | 69 +- tests/tcg/aarch64/Makefile.include | 8 + tests/tcg/aarch64/Makefile.target | 17 + tests/tcg/aarch64/fcvt.ref | 3268 +++++++++++++++++ tests/tcg/alpha/Makefile | 35 - tests/tcg/alpha/Makefile.include | 2 + tests/tcg/alpha/Makefile.target | 18 + tests/tcg/alpha/crt.s | 26 - tests/tcg/alpha/hello-alpha.c | 2 + tests/tcg/alpha/test-cond.c | 1 + tests/tcg/alpha/test-ovf.c | 2 + tests/tcg/arm/Makefile.include | 8 + tests/tcg/arm/Makefile.target | 32 + tests/tcg/arm/README | 11 + tests/tcg/arm/fcvt.c | 458 +++ tests/tcg/arm/fcvt.ref | 3268 +++++++++++++++++ tests/tcg/{ => arm}/hello-arm.c | 0 .../test-arm-iwmmxt.S} | 0 tests/tcg/hppa/Makefile.include | 2 + tests/tcg/hppa/Makefile.target | 6 + tests/tcg/i386/Makefile.include | 9 + tests/tcg/i386/Makefile.target | 51 + tests/tcg/i386/README | 38 + tests/tcg/{ => i386}/hello-i386.c | 1 + tests/tcg/{ => i386}/pi_10.com | Bin tests/tcg/{ => i386}/runcom.c | 0 tests/tcg/{ => i386}/test-i386-code16.S | 0 tests/tcg/{ => i386}/test-i386-fprem.c | 12 +- tests/tcg/{ => i386}/test-i386-muldiv.h | 0 tests/tcg/{ => i386}/test-i386-shift.h | 0 tests/tcg/{ => i386}/test-i386-ssse3.c | 0 tests/tcg/{ => i386}/test-i386-vm86.S | 0 tests/tcg/{ => i386}/test-i386.c | 7 +- tests/tcg/{ => i386}/test-i386.h | 0 tests/tcg/m68k/Makefile.include | 2 + tests/tcg/m68k/Makefile.target | 7 + tests/tcg/mips/Makefile.include | 20 + tests/tcg/mips/Makefile.target | 22 + tests/tcg/mips/README | 7 + tests/tcg/{ => mips}/hello-mips.c | 0 tests/tcg/multiarch/Makefile.target | 36 + tests/tcg/multiarch/README | 1 + tests/tcg/{ => multiarch}/linux-test.c | 113 +- tests/tcg/{ => multiarch}/sha1.c | 0 tests/tcg/{ => multiarch}/test-mmap.c | 40 +- tests/tcg/{ => multiarch}/testthread.c | 0 tests/tcg/ppc/Makefile.include | 7 + tests/tcg/ppc/Makefile.target | 12 + tests/tcg/riscv/Makefile.include | 10 + tests/tcg/s390x/Makefile.include | 2 + tests/tcg/sh4/Makefile.include | 4 + tests/tcg/sh4/Makefile.target | 7 + tests/tcg/sparc64/Makefile.include | 2 + tests/tcg/sparc64/Makefile.target | 11 + tests/tcg/test_path.c | 157 - tests/tcg/x86_64/Makefile.target | 15 + 78 files changed, 8068 insertions(+), 641 deletions(-) create mode 100644 tests/docker/dockerfiles/debian-alpha-cross.docker delete mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh create mode 100644 tests/docker/dockerfiles/debian-hppa-cross.docker create mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker create mode 100644 tests/docker/dockerfiles/debian-mips64-cross.docker create mode 100644 tests/docker/dockerfiles/debian-riscv64-cross.docker create mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker create mode 100644 tests/docker/dockerfiles/debian-sid.docker create mode 100644 tests/docker/dockerfiles/debian-sparc64-cross.docker create mode 100644 tests/tcg/Makefile.include create mode 100644 tests/tcg/Makefile.probe create mode 100644 tests/tcg/aarch64/Makefile.include create mode 100644 tests/tcg/aarch64/Makefile.target create mode 100644 tests/tcg/aarch64/fcvt.ref delete mode 100644 tests/tcg/alpha/Makefile create mode 100644 tests/tcg/alpha/Makefile.include create mode 100644 tests/tcg/alpha/Makefile.target delete mode 100644 tests/tcg/alpha/crt.s create mode 100644 tests/tcg/arm/Makefile.include create mode 100644 tests/tcg/arm/Makefile.target create mode 100644 tests/tcg/arm/README create mode 100644 tests/tcg/arm/fcvt.c create mode 100644 tests/tcg/arm/fcvt.ref rename tests/tcg/{ => arm}/hello-arm.c (100%) rename tests/tcg/{test-arm-iwmmxt.s => arm/test-arm-iwmmxt.S} (100%) create mode 100644 tests/tcg/hppa/Makefile.include create mode 100644 tests/tcg/hppa/Makefile.target create mode 100644 tests/tcg/i386/Makefile.include create mode 100644 tests/tcg/i386/Makefile.target create mode 100644 tests/tcg/i386/README rename tests/tcg/{ => i386}/hello-i386.c (96%) rename tests/tcg/{ => i386}/pi_10.com (100%) rename tests/tcg/{ => i386}/runcom.c (100%) rename tests/tcg/{ => i386}/test-i386-code16.S (100%) rename tests/tcg/{ => i386}/test-i386-fprem.c (97%) rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%) rename tests/tcg/{ => i386}/test-i386-shift.h (100%) rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%) rename tests/tcg/{ => i386}/test-i386-vm86.S (100%) rename tests/tcg/{ => i386}/test-i386.c (99%) rename tests/tcg/{ => i386}/test-i386.h (100%) create mode 100644 tests/tcg/m68k/Makefile.include create mode 100644 tests/tcg/m68k/Makefile.target create mode 100644 tests/tcg/mips/Makefile.include create mode 100644 tests/tcg/mips/Makefile.target create mode 100644 tests/tcg/mips/README rename tests/tcg/{ => mips}/hello-mips.c (100%) create mode 100644 tests/tcg/multiarch/Makefile.target create mode 100644 tests/tcg/multiarch/README rename tests/tcg/{ => multiarch}/linux-test.c (86%) rename tests/tcg/{ => multiarch}/sha1.c (100%) rename tests/tcg/{ => multiarch}/test-mmap.c (93%) rename tests/tcg/{ => multiarch}/testthread.c (100%) create mode 100644 tests/tcg/ppc/Makefile.include create mode 100644 tests/tcg/ppc/Makefile.target create mode 100644 tests/tcg/riscv/Makefile.include create mode 100644 tests/tcg/s390x/Makefile.include create mode 100644 tests/tcg/sh4/Makefile.include create mode 100644 tests/tcg/sh4/Makefile.target create mode 100644 tests/tcg/sparc64/Makefile.include create mode 100644 tests/tcg/sparc64/Makefile.target delete mode 100644 tests/tcg/test_path.c create mode 100644 tests/tcg/x86_64/Makefile.target -- 2.17.1