diff mbox series

[v6,45/49] tests/tcg: override runners for broken tests

Message ID 20180608123307.24773-46-alex.bennee@linaro.org
State Superseded
Headers show
Series fix building of tests/tcg | expand

Commit Message

Alex Bennée June 8, 2018, 12:33 p.m. UTC
To get a clean run of check-tcg these tests are currently skipped:

  - hello-mips for mips
  - linux-test for sparc

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


---
v4
  - document broken tests in commit
  - temporarily demote fcvt while fixes percolate upstream
v5
  - reinstate fcvt
  - remove test-mmap overrides (done with EXTRA_RUNS now)
v6
  - move to after the skip-test helper
---
 tests/tcg/mips/Makefile.target    | 3 +++
 tests/tcg/sparc64/Makefile.target | 7 ++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé June 11, 2018, 1:58 a.m. UTC | #1
On 06/08/2018 09:33 AM, Alex Bennée wrote:
> To get a clean run of check-tcg these tests are currently skipped:

> 

>   - hello-mips for mips

>   - linux-test for sparc

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> 

> ---

> v4

>   - document broken tests in commit

>   - temporarily demote fcvt while fixes percolate upstream

> v5

>   - reinstate fcvt

>   - remove test-mmap overrides (done with EXTRA_RUNS now)

> v6

>   - move to after the skip-test helper

> ---

>  tests/tcg/mips/Makefile.target    | 3 +++

>  tests/tcg/sparc64/Makefile.target | 7 ++++++-

>  2 files changed, 9 insertions(+), 1 deletion(-)

> 

> diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target

> index 71f0c2dd53..086625f533 100644

> --- a/tests/tcg/mips/Makefile.target

> +++ b/tests/tcg/mips/Makefile.target

> @@ -17,3 +17,6 @@ hello-mips: LDFLAGS+=-nostdlib

>  

>  # For MIPS32 and 64 we have a bunch of extra tests in sub-directories

>  # however they are intended for system tests.

> +

> +run-hello-mips: hello-mips

> +	$(call skip-test, $<, "BROKEN")

> diff --git a/tests/tcg/sparc64/Makefile.target b/tests/tcg/sparc64/Makefile.target

> index 408dace783..064c7a598b 100644

> --- a/tests/tcg/sparc64/Makefile.target

> +++ b/tests/tcg/sparc64/Makefile.target

> @@ -1,6 +1,11 @@

>  # -*- Mode: makefile -*-

>  #

> -# sparc specific tweaks

> +# sparc specific tweaks and masking out broken tests

> +

> +# different from the other hangs

> +# /home/alex/lsrc/qemu/qemu.git/tests/tcg/multiarch/linux-test.c:264: Value too large for defined data type (ret=-1, errno=92/Value too large for defined data type)


Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


Dropping "/home/alex/lsrc/qemu/qemu.git/":
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> +run-linux-test: linux-test

> +	$(call skip-test, $<, "BROKEN")

>  

>  # On Sparc64 Linux support 8k pages

>  EXTRA_RUNS+=run-test-mmap-8192

>
diff mbox series

Patch

diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target
index 71f0c2dd53..086625f533 100644
--- a/tests/tcg/mips/Makefile.target
+++ b/tests/tcg/mips/Makefile.target
@@ -17,3 +17,6 @@  hello-mips: LDFLAGS+=-nostdlib
 
 # For MIPS32 and 64 we have a bunch of extra tests in sub-directories
 # however they are intended for system tests.
+
+run-hello-mips: hello-mips
+	$(call skip-test, $<, "BROKEN")
diff --git a/tests/tcg/sparc64/Makefile.target b/tests/tcg/sparc64/Makefile.target
index 408dace783..064c7a598b 100644
--- a/tests/tcg/sparc64/Makefile.target
+++ b/tests/tcg/sparc64/Makefile.target
@@ -1,6 +1,11 @@ 
 # -*- Mode: makefile -*-
 #
-# sparc specific tweaks
+# sparc specific tweaks and masking out broken tests
+
+# different from the other hangs
+# /home/alex/lsrc/qemu/qemu.git/tests/tcg/multiarch/linux-test.c:264: Value too large for defined data type (ret=-1, errno=92/Value too large for defined data type)
+run-linux-test: linux-test
+	$(call skip-test, $<, "BROKEN")
 
 # On Sparc64 Linux support 8k pages
 EXTRA_RUNS+=run-test-mmap-8192