diff mbox series

[v3,01/23] target/openrisc: Fix mtspr shadow gprs

Message ID 20180628030330.15615-2-richard.henderson@linaro.org
State Superseded
Headers show
Series target/openrisc improvements | expand

Commit Message

Richard Henderson June 28, 2018, 3:03 a.m. UTC 
Missing break.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/openrisc/sys_helper.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé June 28, 2018, 2:10 p.m. UTC | #1 
On 06/28/2018 12:03 AM, Richard Henderson wrote:
> Missing break.


"when added in d89e71e873d"?

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> ---

>  target/openrisc/sys_helper.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c

> index b284064381..2f337363ec 100644

> --- a/target/openrisc/sys_helper.c

> +++ b/target/openrisc/sys_helper.c

> @@ -98,6 +98,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env,

>      case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */

>          idx = (spr - 1024);

>          env->shadow_gpr[idx / 32][idx % 32] = rb;

> +        break;

>  

>      case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 */

>          idx = spr - TO_SPR(1, 512);

>
diff mbox series

Patch

diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index b284064381..2f337363ec 100644
--- a/target/openrisc/sys_helper.c
+++ b/target/openrisc/sys_helper.c
@@ -98,6 +98,7 @@  void HELPER(mtspr)(CPUOpenRISCState *env,
     case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */
         idx = (spr - 1024);
         env->shadow_gpr[idx / 32][idx % 32] = rb;
+        break;
 
     case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 */
         idx = spr - TO_SPR(1, 512);