| Message ID | 20200916122648.17468-8-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | configure deprecation, linux-user and test fix | expand |
On Wed, 16 Sep 2020 at 13:27, Alex Bennée <alex.bennee@linaro.org> wrote: > > These targets might be deprecated but we should keep them building > before the final axe comes down. Lets keep them all in one place and > don't hold up the CI if they do fail. They are either poorly tested or > already flaky anyway. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Acked-by: Thomas Huth <thuth@redhat.com> > Message-Id: <20200915134317.11110-8-alex.bennee@linaro.org> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 72e8604579ee..f027b55aef15 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -254,6 +254,16 @@ build-clang: > ppc-softmmu s390x-softmmu arm-linux-user > MAKE_CHECK_ARGS: check > > +# These targets are on the way out > +build-deprecated: > + <<: *native_build_job_definition > + variables: > + IMAGE: debian-all-test-cross > + CONFIGURE_ARGS: --disable-docs --disable-tools --disable-system > + MAKE_CHECK_ARGS: check-tcg > + TARGETS: ppc64abi32-linux-user tilegx-linux-user > + allow_failure: true It's kind of awkward to have the CI config need to be updated when we mark a config as deprecated. Can we have something so that the CI just arranges to build all of the deprecated targets? (As demonstration, this list is missing unicore32, which is also deprecated.) Also, "allow_failure: true" seems wrong to me. These targets are only deprecated, which means we promise that the feature should still work (to whatever extent it already did) for the 2 releases in which it is deprecated. We want our CI to tell us if it fails to compile or fails tests, because we would need to fix those bugs for a release. thanks -- PMM
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 72e8604579ee..f027b55aef15 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -254,6 +254,16 @@ build-clang: ppc-softmmu s390x-softmmu arm-linux-user MAKE_CHECK_ARGS: check +# These targets are on the way out +build-deprecated: + <<: *native_build_job_definition + variables: + IMAGE: debian-all-test-cross + CONFIGURE_ARGS: --disable-docs --disable-tools --disable-system + MAKE_CHECK_ARGS: check-tcg + TARGETS: ppc64abi32-linux-user tilegx-linux-user + allow_failure: true + build-oss-fuzz: <<: *native_build_job_definition variables: diff --git a/.travis.yml b/.travis.yml index 65341634d02a..c75221dca3e7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -344,10 +344,9 @@ jobs: # Run check-tcg against linux-user (with plugins) # we skip sparc64-linux-user until it has been fixed somewhat # we skip cris-linux-user as it doesn't use the common run loop - # we skip ppc64abi32-linux-user as it seems to have a broken libc - name: "GCC plugins check-tcg (user)" env: - - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user,ppc64abi32-linux-user" + - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user,cris-linux-user" - TEST_BUILD_CMD="make build-tcg" - TEST_CMD="make check-tcg" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"