diff mbox series

[v1,2/2] i2c: dev: Use sysfs_emit() in "show" functions

Message ID 20210712142323.23118-2-andriy.shevchenko@linux.intel.com
State Accepted
Commit b18f32d9874ec23f12416c08764d65a318aeb9f6
Headers show
Series None | expand

Commit Message

Andy Shevchenko July 12, 2021, 2:23 p.m. UTC
The sysfs_emit() function was introduced to make it less ambiguous
which function is preferred when writing to the output buffer in
a "show" callback [1].

Convert the I²C device sysfs interface from sprintf() to sysfs_emit()
accordingly, as the latter is aware of the PAGE_SIZE buffer and correctly
returns the number of bytes written into the buffer.

No functional change intended.

[1] Documentation/filesystems/sysfs.rst

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/i2c-dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Aug. 11, 2021, 2:49 p.m. UTC | #1
On Mon, Jul 12, 2021 at 05:23:23PM +0300, Andy Shevchenko wrote:
> The sysfs_emit() function was introduced to make it less ambiguous

> which function is preferred when writing to the output buffer in

> a "show" callback [1].

> 

> Convert the I²C device sysfs interface from sprintf() to sysfs_emit()

> accordingly, as the latter is aware of the PAGE_SIZE buffer and correctly

> returns the number of bytes written into the buffer.

> 

> No functional change intended.

> 

> [1] Documentation/filesystems/sysfs.rst

> 

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index 6cf98c06653a..e2b1aba96401 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -102,7 +102,7 @@  static ssize_t name_show(struct device *dev,
 
 	if (!i2c_dev)
 		return -ENODEV;
-	return sprintf(buf, "%s\n", i2c_dev->adap->name);
+	return sysfs_emit(buf, "%s\n", i2c_dev->adap->name);
 }
 static DEVICE_ATTR_RO(name);