diff mbox series

dt-bindings: iio: adc: exynos-adc: Fix node name in example

Message ID 20211125152154.162780-1-geert@linux-m68k.org
State New
Headers show
Series dt-bindings: iio: adc: exynos-adc: Fix node name in example | expand

Commit Message

Geert Uytterhoeven Nov. 25, 2021, 3:21 p.m. UTC
"make dt_binding_check":

    Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
	    From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 25, 2021, 3:26 p.m. UTC | #1
On 25/11/2021 16:21, Geert Uytterhoeven wrote:
> "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
> 	    From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Jonathan Cameron Nov. 27, 2021, 5:43 p.m. UTC | #2
On Thu, 25 Nov 2021 16:26:16 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:

> On 25/11/2021 16:21, Geert Uytterhoeven wrote:
> > "make dt_binding_check":
> > 
> >     Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
> > 	    From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >   
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
This doesn't particularly feel like we need to rush it in, so applied
to the togreg branch of iio.git which will go in next merge window.

Shout if I should pull it to a fixes branch.

Thanks,

Jonathan

> 
> Best regards,
> Krzysztof
Geert Uytterhoeven Nov. 29, 2021, 8:22 a.m. UTC | #3
Hi Jonathan,

On Sat, Nov 27, 2021 at 6:38 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Thu, 25 Nov 2021 16:26:16 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
> > On 25/11/2021 16:21, Geert Uytterhoeven wrote:
> > > "make dt_binding_check":
> > >
> > >     Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
> > >         From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > ---
> > >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> This doesn't particularly feel like we need to rush it in, so applied
> to the togreg branch of iio.git which will go in next merge window.
>
> Shout if I should pull it to a fixes branch.

Thank you, that's fine. We're still far from the point where we can start
enforcing "no errors" in "make dt_binding_check dtbs_check".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Rob Herring (Arm) Dec. 1, 2021, 10:50 p.m. UTC | #4
On Mon, Nov 29, 2021 at 09:22:35AM +0100, Geert Uytterhoeven wrote:
> Hi Jonathan,
> 
> On Sat, Nov 27, 2021 at 6:38 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Thu, 25 Nov 2021 16:26:16 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
> > > On 25/11/2021 16:21, Geert Uytterhoeven wrote:
> > > > "make dt_binding_check":
> > > >
> > > >     Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
> > > >         From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > ---
> > > >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > >
> > This doesn't particularly feel like we need to rush it in, so applied
> > to the togreg branch of iio.git which will go in next merge window.
> >
> > Shout if I should pull it to a fixes branch.
> 
> Thank you, that's fine. We're still far from the point where we can start
> enforcing "no errors" in "make dt_binding_check dtbs_check".

No errors/warnings is the rule for dt_binding_check, but not dtbs_check.

Jonathan, Can you drop this and I'll apply with some other fixes I have 
for 5.16.

Rob
Jonathan Cameron Dec. 4, 2021, 3:35 p.m. UTC | #5
On Wed, 1 Dec 2021 16:50:10 -0600
Rob Herring <robh@kernel.org> wrote:

> On Mon, Nov 29, 2021 at 09:22:35AM +0100, Geert Uytterhoeven wrote:
> > Hi Jonathan,
> > 
> > On Sat, Nov 27, 2021 at 6:38 PM Jonathan Cameron <jic23@kernel.org> wrote:  
> > > On Thu, 25 Nov 2021 16:26:16 +0100
> > > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:  
> > > > On 25/11/2021 16:21, Geert Uytterhoeven wrote:  
> > > > > "make dt_binding_check":
> > > > >
> > > > >     Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.example.dt.yaml: ncp15wb473: $nodename:0: 'ncp15wb473' does not match '^thermistor(.*)?$'
> > > > >         From schema: Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > ---
> > > > >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml         | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >  
> > > >
> > > >
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > > >  
> > > This doesn't particularly feel like we need to rush it in, so applied
> > > to the togreg branch of iio.git which will go in next merge window.
> > >
> > > Shout if I should pull it to a fixes branch.  
> > 
> > Thank you, that's fine. We're still far from the point where we can start
> > enforcing "no errors" in "make dt_binding_check dtbs_check".  
> 
> No errors/warnings is the rule for dt_binding_check, but not dtbs_check.
> 
> Jonathan, Can you drop this and I'll apply with some other fixes I have 
> for 5.16.
> 
> Rob

Done, it's all yours.  Feel free to add

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

if you haven't already pushed it out.

THanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index c65921e66dc1f4d0..81c87295912cec04 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -136,7 +136,7 @@  examples:
         samsung,syscon-phandle = <&pmu_system_controller>;
 
         /* NTC thermistor is a hwmon device */
-        ncp15wb473 {
+        thermistor {
             compatible = "murata,ncp15wb473";
             pullup-uv = <1800000>;
             pullup-ohm = <47000>;