| Message ID | 20220907144624.2810117-3-alexander.stein@ew.tq-group.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | USB host support for TQMa8MPxL + MBa8MPxL | expand |
> -----Original Message----- > From: Alexander Stein <alexander.stein@ew.tq-group.com> > Sent: Wednesday, September 7, 2022 10:46 PM > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>; > Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx > <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com> > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>; > linux-usb@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: [PATCH 2/4] usb: dwc3: core: add gfladj_refclk_lpm_sel quirk > > This selects the SOF/ITP counter be running on ref_clk. As documented > U2_FREECLK_EXISTS has to be set to 0 as well. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Li Jun <jun.li@nxp.com> > --- > drivers/usb/dwc3/core.c | 8 +++++++- > drivers/usb/dwc3/core.h | 2 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index > 8c8e32651473..12e8e7d34cb8 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -408,6 +408,10 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc) > reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj) > | FIELD_PREP(DWC3_GFLADJ_240MHZDECR, decr >> 1) > | FIELD_PREP(DWC3_GFLADJ_240MHZDECR_PLS1, decr & 1); > + > + if (dwc->gfladj_refclk_lpm_sel) > + reg |= DWC3_GFLADJ_REFCLK_LPM_SEL; > + > dwc3_writel(dwc->regs, DWC3_GFLADJ, reg); } > > @@ -789,7 +793,7 @@ static int dwc3_phy_setup(struct dwc3 *dwc) > else > reg |= DWC3_GUSB2PHYCFG_ENBLSLPM; > > - if (dwc->dis_u2_freeclk_exists_quirk) > + if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel) > reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS; > > dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); @@ -1525,6 +1529,8 > @@ static void dwc3_get_properties(struct dwc3 *dwc) > "snps,dis-tx-ipgap-linecheck-quirk"); > dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev, > "snps,parkmode-disable-ss-quirk"); > + dwc->gfladj_refclk_lpm_sel = device_property_read_bool(dev, > + "snps,gfladj-refclk-lpm-sel-quirk"); > > dwc->tx_de_emphasis_quirk = device_property_read_bool(dev, > "snps,tx_de_emphasis_quirk"); > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index > 4fe4287dc934..11975a03316f 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -391,6 +391,7 @@ > #define DWC3_GFLADJ_30MHZ_SDBND_SEL BIT(7) > #define DWC3_GFLADJ_30MHZ_MASK 0x3f > #define DWC3_GFLADJ_REFCLK_FLADJ_MASK GENMASK(21, 8) > +#define DWC3_GFLADJ_REFCLK_LPM_SEL BIT(23) > #define DWC3_GFLADJ_240MHZDECR GENMASK(30, 24) > #define DWC3_GFLADJ_240MHZDECR_PLS1 BIT(31) > > @@ -1312,6 +1313,7 @@ struct dwc3 { > unsigned dis_del_phy_power_chg_quirk:1; > unsigned dis_tx_ipgap_linecheck_quirk:1; > unsigned parkmode_disable_ss_quirk:1; > + unsigned gfladj_refclk_lpm_sel:1; > > unsigned tx_de_emphasis_quirk:1; > unsigned tx_de_emphasis:2; > -- > 2.25.1
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 8c8e32651473..12e8e7d34cb8 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -408,6 +408,10 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc) reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj) | FIELD_PREP(DWC3_GFLADJ_240MHZDECR, decr >> 1) | FIELD_PREP(DWC3_GFLADJ_240MHZDECR_PLS1, decr & 1); + + if (dwc->gfladj_refclk_lpm_sel) + reg |= DWC3_GFLADJ_REFCLK_LPM_SEL; + dwc3_writel(dwc->regs, DWC3_GFLADJ, reg); } @@ -789,7 +793,7 @@ static int dwc3_phy_setup(struct dwc3 *dwc) else reg |= DWC3_GUSB2PHYCFG_ENBLSLPM; - if (dwc->dis_u2_freeclk_exists_quirk) + if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel) reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS; dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); @@ -1525,6 +1529,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) "snps,dis-tx-ipgap-linecheck-quirk"); dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev, "snps,parkmode-disable-ss-quirk"); + dwc->gfladj_refclk_lpm_sel = device_property_read_bool(dev, + "snps,gfladj-refclk-lpm-sel-quirk"); dwc->tx_de_emphasis_quirk = device_property_read_bool(dev, "snps,tx_de_emphasis_quirk"); diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 4fe4287dc934..11975a03316f 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -391,6 +391,7 @@ #define DWC3_GFLADJ_30MHZ_SDBND_SEL BIT(7) #define DWC3_GFLADJ_30MHZ_MASK 0x3f #define DWC3_GFLADJ_REFCLK_FLADJ_MASK GENMASK(21, 8) +#define DWC3_GFLADJ_REFCLK_LPM_SEL BIT(23) #define DWC3_GFLADJ_240MHZDECR GENMASK(30, 24) #define DWC3_GFLADJ_240MHZDECR_PLS1 BIT(31) @@ -1312,6 +1313,7 @@ struct dwc3 { unsigned dis_del_phy_power_chg_quirk:1; unsigned dis_tx_ipgap_linecheck_quirk:1; unsigned parkmode_disable_ss_quirk:1; + unsigned gfladj_refclk_lpm_sel:1; unsigned tx_de_emphasis_quirk:1; unsigned tx_de_emphasis:2;
This selects the SOF/ITP counter be running on ref_clk. As documented U2_FREECLK_EXISTS has to be set to 0 as well. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/usb/dwc3/core.c | 8 +++++++- drivers/usb/dwc3/core.h | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-)