Message ID | 20220927141504.3886314-4-alex.bennee@linaro.org |
---|---|
State | Superseded |
Headers | show |
Series | gdbstub/next (MemTxAttrs, re-factoring) | expand |
On 9/27/22 07:14, Alex Bennée wrote: > As most HVF devices are done purely in software we need to make sure > we properly encode the source CPU in MemTxAttrs. This will allow the > device emulations to use those attributes rather than relying on > current_cpu (although current_cpu will still be correct in this case). > > Acked-by: Alexander Graf<agraf@csgraf.de> > Signed-off-by: Alex Bennée<alex.bennee@linaro.org> > Cc: Mads Ynddal<mads@ynddal.dk> > > --- > v2 > - update MEMTXATTRS macro > --- > target/arm/hvf/hvf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
> As most HVF devices are done purely in software we need to make sure > we properly encode the source CPU in MemTxAttrs. This will allow the > device emulations to use those attributes rather than relying on > current_cpu (although current_cpu will still be correct in this case). > > Acked-by: Alexander Graf <agraf@csgraf.de> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Mads Ynddal <mads@ynddal.dk> > > --- > v2 > - update MEMTXATTRS macro > --- > target/arm/hvf/hvf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Mads Ynddal <mads@ynddal.dk>
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 060aa0ccf4..d81fbbb2df 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1233,11 +1233,11 @@ int hvf_vcpu_exec(CPUState *cpu) val = hvf_get_reg(cpu, srt); address_space_write(&address_space_memory, hvf_exit->exception.physical_address, - MEMTXATTRS_UNSPECIFIED, &val, len); + MEMTXATTRS_CPU(cpu), &val, len); } else { address_space_read(&address_space_memory, hvf_exit->exception.physical_address, - MEMTXATTRS_UNSPECIFIED, &val, len); + MEMTXATTRS_CPU(cpu), &val, len); hvf_set_reg(cpu, srt, val); }