diff mbox series

[3/3] dt-bindings: mfd: qcom,spmi-pmic: use generic node name "gpio"

Message ID 20220908080938.29199-3-krzysztof.kozlowski@linaro.org
State Accepted
Commit 4bef4d519b01cf15818b81a3fbf62d9f51612ad3
Headers show
Series None | expand

Commit Message

Krzysztof Kozlowski Sept. 8, 2022, 8:09 a.m. UTC
GPIO controller nodes are named by convention just "gpio", not "gpios".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Rob Herring (Arm) Sept. 12, 2022, 9:41 p.m. UTC | #1
On Thu, 08 Sep 2022 10:09:38 +0200, Krzysztof Kozlowski wrote:
> GPIO controller nodes are named by convention just "gpio", not "gpios".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Lee Jones Sept. 28, 2022, 9:41 a.m. UTC | #2
On Thu, 08 Sep 2022, Krzysztof Kozlowski wrote:

> GPIO controller nodes are named by convention just "gpio", not "gpios".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I guess I can't take this until the 2 arch/ patches are applied.
Krzysztof Kozlowski Sept. 28, 2022, 11:05 a.m. UTC | #3
On 28/09/2022 11:41, Lee Jones wrote:
> On Thu, 08 Sep 2022, Krzysztof Kozlowski wrote:
> 
>> GPIO controller nodes are named by convention just "gpio", not "gpios".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> I guess I can't take this until the 2 arch/ patches are applied.

You can. It will warn when running dtbs_check, but that's not a big
deal. Anyway DTS patches wait for quite a while, so there was enough of
time for them to get to next.

Best regards,
Krzysztof
Lee Jones Sept. 29, 2022, 4:52 p.m. UTC | #4
On Wed, 28 Sep 2022, Krzysztof Kozlowski wrote:

> On 28/09/2022 11:41, Lee Jones wrote:
> > On Thu, 08 Sep 2022, Krzysztof Kozlowski wrote:
> > 
> >> GPIO controller nodes are named by convention just "gpio", not "gpios".
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > I guess I can't take this until the 2 arch/ patches are applied.
> 
> You can. It will warn when running dtbs_check, but that's not a big
> deal. Anyway DTS patches wait for quite a while, so there was enough of
> time for them to get to next.

I'll apply them after -rc1. :thumb
Lee Jones Oct. 24, 2022, 12:54 p.m. UTC | #5
On Thu, 08 Sep 2022, Krzysztof Kozlowski wrote:

> GPIO controller nodes are named by convention just "gpio", not "gpios".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 9676a9e3d176..6afe8f03314d 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -117,7 +117,7 @@  patternProperties:
     type: object
     $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
 
-  "gpio(s)?@[0-9a-f]+$":
+  "gpio@[0-9a-f]+$":
     type: object
     $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
 
@@ -197,7 +197,7 @@  examples:
             #address-cells = <1>;
             #size-cells = <0>;
 
-            pmi8998_gpio: gpios@c000 {
+            pmi8998_gpio: gpio@c000 {
                 compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
                 reg = <0xc000>;
                 gpio-controller;
@@ -282,7 +282,7 @@  examples:
             };
         };
 
-        pm6150_gpio: gpios@c000 {
+        pm6150_gpio: gpio@c000 {
             compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio";
             reg = <0xc000>;
             gpio-controller;