diff mbox series

[1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon node name

Message ID 20221031175717.942237-1-luca@z3ntu.xyz
State Accepted
Commit 0867c49146c2145ecfb07d6d03071cdbeae9b6e1
Headers show
Series [1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon node name | expand

Commit Message

Luca Weiss Oct. 31, 2022, 5:57 p.m. UTC
extcon is a Linux-specific name and shouldn't be a part of the dts. Make
it be called usb-detect@ instead.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
This patch builds on top of
https://lore.kernel.org/linux-arm-msm/20221031173933.936147-1-luca@z3ntu.xyz/
But could also be applied without, if conflicts are resolved.

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Rob Herring (Arm) Nov. 2, 2022, 4:27 p.m. UTC | #1
On Mon, 31 Oct 2022 18:57:14 +0100, Luca Weiss wrote:
> extcon is a Linux-specific name and shouldn't be a part of the dts. Make
> it be called usb-detect@ instead.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> This patch builds on top of
> https://lore.kernel.org/linux-arm-msm/20221031173933.936147-1-luca@z3ntu.xyz/
> But could also be applied without, if conflicts are resolved.
> 
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Luca Weiss Nov. 7, 2022, 12:49 p.m. UTC | #2
On Montag, 7. November 2022 10:08:16 CET Lee Jones wrote:
> On Mon, 31 Oct 2022, Luca Weiss wrote:
> > extcon is a Linux-specific name and shouldn't be a part of the dts. Make
> > it be called usb-detect@ instead.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > This patch builds on top of
> > https://lore.kernel.org/linux-arm-msm/20221031173933.936147-1-luca@z3ntu.x
> > yz/ But could also be applied without, if conflicts are resolved.
> > 
> >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Same here.  Only 1/3 received.
> 
> Can I take this on its own?

Hi,

yes, this can be taken on its own. Perhaps it'll introduce some temporary 
dtbs_check warnings until the other patches have also made it into the tree.

Patch 2 is pm8941-misc yaml change, and patch 3 is adjusting dtsi file for the 
new name.

Lore: https://lore.kernel.org/lkml/20221031175717.942237-1-luca@z3ntu.xyz/

Regards
Luca

> 
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index
> > cf10d62ace54..14aa42057d6f 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > 
> > @@ -123,10 +123,6 @@ patternProperties:
> >        - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> >        - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > 
> > -  "extcon@[0-9a-f]+$":
> > -    type: object
> > -    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> > -
> > 
> >    "gpio(s)?@[0-9a-f]+$":
> >      type: object
> >      $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
> > 
> > @@ -143,6 +139,10 @@ patternProperties:
> >      type: object
> >      $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
> > 
> > +  "^usb-detect@[0-9a-f]+$":
> > +    type: object
> > +    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> > +
> > 
> >    "^usb-vbus-regulator@[0-9a-f]+$":
> >      type: object
> >      $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
Bjorn Andersson Nov. 8, 2022, 1:27 a.m. UTC | #3
On Mon, 31 Oct 2022 18:57:14 +0100, Luca Weiss wrote:
> extcon is a Linux-specific name and shouldn't be a part of the dts. Make
> it be called usb-detect@ instead.
> 
> 

Applied, thanks!

[3/3] ARM: dts: qcom: pm8941: rename misc node name
      commit: 52c47b894b260c3e5102bb4b3e77772734508bcf

Best regards,
Lee Jones Nov. 16, 2022, 2:05 p.m. UTC | #4
On Mon, 31 Oct 2022, Luca Weiss wrote:

> extcon is a Linux-specific name and shouldn't be a part of the dts. Make
> it be called usb-detect@ instead.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> This patch builds on top of
> https://lore.kernel.org/linux-arm-msm/20221031173933.936147-1-luca@z3ntu.xyz/
> But could also be applied without, if conflicts are resolved.
> 
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index cf10d62ace54..14aa42057d6f 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -123,10 +123,6 @@  patternProperties:
       - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
       - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
 
-  "extcon@[0-9a-f]+$":
-    type: object
-    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
-
   "gpio(s)?@[0-9a-f]+$":
     type: object
     $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
@@ -143,6 +139,10 @@  patternProperties:
     type: object
     $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
 
+  "^usb-detect@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
+
   "^usb-vbus-regulator@[0-9a-f]+$":
     type: object
     $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#