diff mbox series

[v4,10/18] dt-bindings: mfd: qcom,spmi-pmic: Add pdphy to SPMI device types

Message ID 20230318121828.739424-11-bryan.odonoghue@linaro.org
State New
Headers show
Series Add Qualcomm PMIC TPCM support | expand

Commit Message

Bryan O'Donoghue March 18, 2023, 12:18 p.m. UTC
The PDPHY sits inside of the PMIC SPMI block providing register-level
ability to read/write USB Type-C Power Delivery protocol packets over the
SBU pins.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski March 19, 2023, 11:58 a.m. UTC | #1
On 18/03/2023 13:18, Bryan O'Donoghue wrote:
> The PDPHY sits inside of the PMIC SPMI block providing register-level
> ability to read/write USB Type-C Power Delivery protocol packets over the
> SBU pins.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 8f076bb622b15..111aec53caeb5 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -140,6 +140,10 @@ patternProperties:
>      type: object
>      $ref: /schemas/power/reset/qcom,pon.yaml#
>  
> +  "pdphy@[0-9a-f]+$":

phy@



Best regards,
Krzysztof
Rob Herring March 21, 2023, 8:58 p.m. UTC | #2
On Sun, Mar 19, 2023 at 12:58:48PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2023 13:18, Bryan O'Donoghue wrote:
> > The PDPHY sits inside of the PMIC SPMI block providing register-level
> > ability to read/write USB Type-C Power Delivery protocol packets over the
> > SBU pins.
> > 
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > index 8f076bb622b15..111aec53caeb5 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > @@ -140,6 +140,10 @@ patternProperties:
> >      type: object
> >      $ref: /schemas/power/reset/qcom,pon.yaml#
> >  
> > +  "pdphy@[0-9a-f]+$":
> 
> phy@

But it is not a phy which I would define as something doing digital to 
analog (or vice-versa) signal conversion/encoding. Sounds like an SBU 
controller or something...

Rob
Bryan O'Donoghue March 21, 2023, 11:52 p.m. UTC | #3
On 21/03/2023 20:58, Rob Herring wrote:
> On Sun, Mar 19, 2023 at 12:58:48PM +0100, Krzysztof Kozlowski wrote:
>> On 18/03/2023 13:18, Bryan O'Donoghue wrote:
>>> The PDPHY sits inside of the PMIC SPMI block providing register-level
>>> ability to read/write USB Type-C Power Delivery protocol packets over the
>>> SBU pins.
>>>
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> ---
>>>   Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> index 8f076bb622b15..111aec53caeb5 100644
>>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> @@ -140,6 +140,10 @@ patternProperties:
>>>       type: object
>>>       $ref: /schemas/power/reset/qcom,pon.yaml#
>>>   
>>> +  "pdphy@[0-9a-f]+$":
>>
>> phy@
> 
> But it is not a phy which I would define as something doing digital to
> analog (or vice-versa) signal conversion/encoding. Sounds like an SBU
> controller or something...
> 
> Rob

Its an SBU controller.

---
bod
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 8f076bb622b15..111aec53caeb5 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -140,6 +140,10 @@  patternProperties:
     type: object
     $ref: /schemas/power/reset/qcom,pon.yaml#
 
+  "pdphy@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/usb/qcom,pmic-pdphy.yaml#
+
   "^rtc@[0-9a-f]+$":
     type: object
     $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#