| Message ID | 20230324135249.9733-1-thenzl@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | megaraid_sas: a fix in fw_crash_buffer_show | expand |
Tomas, > If crash_dump_buf is not allocated then crash dump can't be > available. Replace logical 'and' with 'or'. Applied to 6.3/scsi-fixes, thanks! [1/1] scsi: megaraid_sas: Fix fw_crash_buffer_show() https://git.kernel.org/mkp/scsi/c/0808ed6ebbc2
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 63ea0aed47aa..c9e2aa2f952f 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -3298,7 +3298,7 @@ fw_crash_buffer_show(struct device *cdev, spin_lock_irqsave(&instance->crashdump_lock, flags); buff_offset = instance->fw_crash_buffer_offset; - if (!instance->crash_dump_buf && + if (!instance->crash_dump_buf || !((instance->fw_crash_state == AVAILABLE) || (instance->fw_crash_state == COPYING))) { dev_err(&instance->pdev->dev,
If crash_dump_buf is not allocated then crash dump can't be available. Replace logical 'and' with 'or'. Signed-off-by: Tomas Henzl <thenzl@redhat.com> --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)