| Message ID | 20230407175807.124394-5-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] arm64: dts: qcom: msm8994: remove superfluous "input-enable" | expand |
On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote: > Pin configuration property "input-enable" was used with the intention to > disable the output, but this is done by default by Linux drivers. Since > patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not > input-enable") the property is not accepted anymore. This description does not seem to match the pin configurations that you are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl" binding for which 'input-enable' is still accepted AFAICT. Perhaps you can fix up the lpass bindings (and driver?) to match? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 4c75da1bac2d..5632c3b8e416 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2728,7 +2728,6 @@ data-pins { > pins = "gpio7"; > function = "dmic1_data"; > drive-strength = <8>; > - input-enable; > }; > }; Johan
On 11/04/2023 16:12, Johan Hovold wrote: > On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote: >> Pin configuration property "input-enable" was used with the intention to >> disable the output, but this is done by default by Linux drivers. Since >> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not >> input-enable") the property is not accepted anymore. > > This description does not seem to match the pin configurations that you > are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl" > binding for which 'input-enable' is still accepted AFAICT. > > Perhaps you can fix up the lpass bindings (and driver?) to match? Thanks for spotting this. This change is wrong. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 4c75da1bac2d..5632c3b8e416 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -2728,7 +2728,6 @@ data-pins { pins = "gpio7"; function = "dmic1_data"; drive-strength = <8>; - input-enable; }; }; @@ -2746,7 +2745,6 @@ data-pins { function = "dmic1_data"; drive-strength = <2>; bias-pull-down; - input-enable; }; }; @@ -2762,7 +2760,6 @@ data-pins { pins = "gpio9"; function = "dmic2_data"; drive-strength = <8>; - input-enable; }; }; @@ -2780,7 +2777,6 @@ data-pins { function = "dmic2_data"; drive-strength = <2>; bias-pull-down; - input-enable; }; };
Pin configuration property "input-enable" was used with the intention to disable the output, but this is done by default by Linux drivers. Since patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable") the property is not accepted anymore. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ---- 1 file changed, 4 deletions(-)