diff mbox

[v2,08/15] ASoC: TTC DKB audio needs I2C

Message ID 1398763412-18928-9-git-send-email-kaixu.xia@linaro.org
State New
Headers show

Commit Message

Xia Kaixu April 29, 2014, 9:23 a.m. UTC 
The missing dependency can lead to build errors, so
make it explicit in Kconfig.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Xia Kaixu <kaixu.xia@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Philipp Zabel <philipp.zabel@gmail.com>
Cc: Paul Parsons <lost.distance@yahoo.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-arm-kernel@lists.infradead.org
---
 sound/soc/pxa/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann April 29, 2014, 9:38 a.m. UTC | #1 
On Tuesday 29 April 2014 17:23:25 Xia Kaixu wrote:
> The missing dependency can lead to build errors, so
> make it explicit in Kconfig.

This patch and the following few ones that you have split up
are missing the attribution to me as the original author.

Since you have split them up and they are basically one-line
patches, it's fine to have you as the author, but then you
should remove my 'Signed-off-by' line as well. You can
add an 'Acked-by' with my address instead.

Alternatively, you can keep my Signed-off-by, and change
the author using 'git commit --amend --author="Arnd Bergmann
<arnd@arndb.de>"'.

	Arnd
diff mbox

Patch

diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index 6473052..6acb225 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -140,7 +140,7 @@  config SND_PXA910_SOC
 
 config SND_SOC_TTC_DKB
 	bool "SoC Audio support for TTC DKB"
-	depends on SND_PXA910_SOC && MACH_TTC_DKB
+	depends on SND_PXA910_SOC && MACH_TTC_DKB && I2C=y
 	select PXA_SSP
 	select SND_PXA_SOC_SSP
 	select SND_MMP_SOC