[PULL,07/28] target/arm: add LOG_UNIMP messages to arm-semi

Message ID	20190528094953.14898-8-alex.bennee@linaro.org
State	Accepted
Commit	a131795f4c696083708767a2cb7e1168f73a1690
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org> To: peter.maydell@linaro.org Date: Tue, 28 May 2019 10:49:32 +0100 Message-Id: <20190528094953.14898-8-alex.bennee@linaro.org> In-Reply-To: <20190528094953.14898-1-alex.bennee@linaro.org> References: <20190528094953.14898-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 07/28] target/arm: add LOG_UNIMP messages to arm-semi Precedence: list Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org, "open list:ARM" <qemu-arm@nongnu.org> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	testing/next (system tests, docker, iotests) \| expand [PULL,00/28] testing/next (system tests, docker, iotests) [PULL,01/28] semihosting: move semihosting configuration into its own directory [PULL,02/28] semihosting: introduce CONFIG_SEMIHOSTING [PULL,03/28] semihosting: implement a semihosting console [PULL,04/28] semihosting: enable chardev backed output for console [PULL,05/28] target/arm: fixup some of the commentary for arm-semi [PULL,06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi [PULL,07/28] target/arm: add LOG_UNIMP messages to arm-semi [PULL,08/28] target/arm: correct return values for WRITE/READ in arm-semi [PULL,09/28] target/mips: only build mips-semi for softmmu [PULL,10/28] target/mips: convert UHI_plog to use common semihosting code [PULL,11/28] MAINTAINERS: update for semihostings new home [PULL,12/28] tests/docker: add ubuntu 18.04 [PULL,13/28] tests/docker: Test more components on the Fedora default image [PULL,14/28] tests/tcg/multiarch: add support for multiarch system tests [PULL,15/28] tests/tcg/multiarch: add hello world system test [PULL,16/28] editorconfig: add settings for .s/.S files [PULL,17/28] tests/tcg/aarch64: add system boot.S [PULL,18/28] tests/tcg/multiarch: move the system memory test [PULL,19/28] tests/tcg/minilib: support %c format char [PULL,20/28] tests/tcg/multiarch: expand system memory test to cover more [PULL,21/28] tests/tcg/alpha: add system boot.S [PULL,22/28] .travis.yml: enable aarch64-softmmu and alpha-softmmu tcg tests [PULL,23/28] Makefile: fix coverage-report reference to BUILD_DIR [PULL,24/28] Makefile: include per-target build directories in coverage report [PULL,25/28] Makefile.target: support per-target coverage reports [PULL,26/28] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run [PULL,27/28] tests/qemu-iotests: re-format output to for make check-block [PULL,28/28] tests: Run the iotests during "make check" again

Message ID

20190528094953.14898-8-alex.bennee@linaro.org

State

Accepted

Commit

a131795f4c696083708767a2cb7e1168f73a1690

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Date: Tue, 28 May 2019 10:49:32 +0100
Message-Id: <20190528094953.14898-8-alex.bennee@linaro.org>
In-Reply-To: <20190528094953.14898-1-alex.bennee@linaro.org>
References: <20190528094953.14898-1-alex.bennee@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PULL 07/28] target/arm: add LOG_UNIMP messages to
	arm-semi
Precedence: list
Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Alex_Benn?=
	=?utf-8?b?w6ll?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org,
	"open list:ARM" <qemu-arm@nongnu.org>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

testing/next (system tests, docker, iotests) | expand

Commit Message

Alex Bennée May 28, 2019, 9:49 a.m. UTC

Clean-up our unimplemented bits with a proper message.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


-- 
2.20.1

diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c
index 384b01124e1..86e6ec48c2f 100644
--- a/target/arm/arm-semi.c
+++ b/target/arm/arm-semi.c
@@ -28,6 +28,7 @@ 
 #include "cpu.h"
 #include "hw/semihosting/semihost.h"
 #include "hw/semihosting/console.h"
+#include "qemu/log.h"
 #ifdef CONFIG_USER_ONLY
 #include "qemu.h"
 
@@ -363,7 +364,7 @@  target_ulong do_arm_semihosting(CPUARMState *env)
             return len - ret;
         }
     case TARGET_SYS_READC:
-       /* XXX: Read from debug console. Not implemented.  */
+        qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__);
         return 0;
     case TARGET_SYS_ISTTY:
         GET_ARG(0);
@@ -397,7 +398,7 @@  target_ulong do_arm_semihosting(CPUARMState *env)
             return buf.st_size;
         }
     case TARGET_SYS_TMPNAM:
-        /* XXX: Not implemented.  */
+        qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__);
         return -1;
     case TARGET_SYS_REMOVE:
         GET_ARG(0);

[PULL,07/28] target/arm: add LOG_UNIMP messages to arm-semi

Commit Message

Patch