diff mbox series

[v3,04/14] dt-bindings: mailbox: qcom: Add clock-name optional property

Message ID 20190625164733.11091-5-jorge.ramirez-ortiz@linaro.org
State Accepted
Commit 4316ec05da997c20f74005753d228765e369a1cb
Headers show
Series Support CPU frequency scaling on QCS404 | expand

Commit Message

Jorge Ramirez-Ortiz June 25, 2019, 4:47 p.m. UTC
When the APCS clock is registered (platform dependent), it retrieves
its parent names from hardcoded values in the driver.

The following commit allows the DT node to provide such clock names to
the platform data based clock driver therefore avoiding having to
explicitly embed those names in the clock driver source code.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

Reviewed-by: Rob Herring <robh@kernel.org>

---
 .../mailbox/qcom,apcs-kpss-global.txt         | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

-- 
2.21.0

Comments

Bjorn Andersson July 11, 2019, 2:45 p.m. UTC | #1
On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote:

> When the APCS clock is registered (platform dependent), it retrieves

> its parent names from hardcoded values in the driver.

> 

> The following commit allows the DT node to provide such clock names to

> the platform data based clock driver therefore avoiding having to

> explicitly embed those names in the clock driver source code.

> 

> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>

> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

> Reviewed-by: Rob Herring <robh@kernel.org>


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


> ---

>  .../mailbox/qcom,apcs-kpss-global.txt         | 24 ++++++++++++++++---

>  1 file changed, 21 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt

> index 1232fc9fc709..b69310322b09 100644

> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt

> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt

> @@ -18,10 +18,11 @@ platforms.

>  	Usage: required

>  	Value type: <prop-encoded-array>

>  	Definition: must specify the base address and size of the global block

> +

>  - clocks:

> -	Usage: required if #clocks-cells property is present

> -	Value type: <phandle>

> -	Definition: phandle to the input PLL, which feeds the APCS mux/divider

> +	Usage: required if #clock-names property is present

> +	Value type: <phandle array>

> +	Definition: phandles to the two parent clocks of the clock driver.

>  

>  - #mbox-cells:

>  	Usage: required

> @@ -33,6 +34,12 @@ platforms.

>  	Value type: <u32>

>  	Definition: as described in clock.txt, must be 0

>  

> +- clock-names:

> +	Usage: required if the platform data based clock driver needs to

> +	retrieve the parent clock names from device tree.

> +	This will requires two mandatory clocks to be defined.

> +	Value type: <string-array>

> +	Definition: must be "aux" and "pll"

>  

>  = EXAMPLE

>  The following example describes the APCS HMSS found in MSM8996 and part of the

> @@ -65,3 +72,14 @@ Below is another example of the APCS binding on MSM8916 platforms:

>  		clocks = <&a53pll>;

>  		#clock-cells = <0>;

>  	};

> +

> +Below is another example of the APCS binding on QCS404 platforms:

> +

> +	apcs_glb: mailbox@b011000 {

> +		compatible = "qcom,qcs404-apcs-apps-global", "syscon";

> +		reg = <0x0b011000 0x1000>;

> +		#mbox-cells = <1>;

> +		clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;

> +		clock-names = "aux", "pll";

> +		#clock-cells = <0>;

> +	};

> -- 

> 2.21.0

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
index 1232fc9fc709..b69310322b09 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
@@ -18,10 +18,11 @@  platforms.
 	Usage: required
 	Value type: <prop-encoded-array>
 	Definition: must specify the base address and size of the global block
+
 - clocks:
-	Usage: required if #clocks-cells property is present
-	Value type: <phandle>
-	Definition: phandle to the input PLL, which feeds the APCS mux/divider
+	Usage: required if #clock-names property is present
+	Value type: <phandle array>
+	Definition: phandles to the two parent clocks of the clock driver.
 
 - #mbox-cells:
 	Usage: required
@@ -33,6 +34,12 @@  platforms.
 	Value type: <u32>
 	Definition: as described in clock.txt, must be 0
 
+- clock-names:
+	Usage: required if the platform data based clock driver needs to
+	retrieve the parent clock names from device tree.
+	This will requires two mandatory clocks to be defined.
+	Value type: <string-array>
+	Definition: must be "aux" and "pll"
 
 = EXAMPLE
 The following example describes the APCS HMSS found in MSM8996 and part of the
@@ -65,3 +72,14 @@  Below is another example of the APCS binding on MSM8916 platforms:
 		clocks = <&a53pll>;
 		#clock-cells = <0>;
 	};
+
+Below is another example of the APCS binding on QCS404 platforms:
+
+	apcs_glb: mailbox@b011000 {
+		compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+		reg = <0x0b011000 0x1000>;
+		#mbox-cells = <1>;
+		clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;
+		clock-names = "aux", "pll";
+		#clock-cells = <0>;
+	};