diff mbox series

[1/8] pinctrl: renesas: Remove superfluous goto in sh_pfc_gpio_set_direction()

Message ID 20201028151637.1734130-2-geert+renesas@glider.be
State Accepted
Commit b5bd0becfd42e6d007ad559c9068b80ef3ff84b8
Headers show
Series pinctrl: renesas: Cleanups and improvements | expand

Commit Message

Geert Uytterhoeven Oct. 28, 2020, 3:16 p.m. UTC
Commit b13431ed6eab808a ("pinctrl: sh-pfc: Remove incomplete flag
"cfg->type"") removed the last statement in between the goto and the
label.  Hence remove both.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/renesas/pinctrl.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/drivers/pinctrl/renesas/pinctrl.c b/drivers/pinctrl/renesas/pinctrl.c
index 212a4a9c3a8fc1c7..f8d5fae66e862fd6 100644
--- a/drivers/pinctrl/renesas/pinctrl.c
+++ b/drivers/pinctrl/renesas/pinctrl.c
@@ -460,12 +460,7 @@  static int sh_pfc_gpio_set_direction(struct pinctrl_dev *pctldev,
 	}
 
 	spin_lock_irqsave(&pfc->lock, flags);
-
 	ret = sh_pfc_config_mux(pfc, pin->enum_id, new_type);
-	if (ret < 0)
-		goto done;
-
-done:
 	spin_unlock_irqrestore(&pfc->lock, flags);
 	return ret;
 }