| Message ID | 20210228055645.22253-4-chaitanya.kulkarni@wdc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [01/23] target/iblock: remove an extra argument | expand |
On 28/02/2021 07:00, Chaitanya Kulkarni wrote: > " Â 147 Â * ilog2 - log base 2 of 32-bit or a 64-bit unsigned value" Not sure if it's only my mail client, but there's some stray characters in the quotation. Code wise it looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index db9bd571acb1..12999d39c398 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -813,7 +813,7 @@ static unsigned int iblock_get_lbppbe(struct se_device *dev) { struct iblock_dev *ib_dev = IBLOCK_DEV(dev); struct block_device *bd = ib_dev->ibd_bd; - int logs_per_phys = + unsigned int logs_per_phys = bdev_physical_block_size(bd) / bdev_logical_block_size(bd); return ilog2(logs_per_phys);
According to the ilog2() it expects 32/64 bit unsigned value. " 147 * ilog2 - log base 2 of 32-bit or a 64-bit unsigned value" Replace the type of the logs_per_phys from int to unsigned int. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- drivers/target/target_core_iblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)