diff mbox series

[net-next,1/2] tipc: convert dest node's address to network order

Message ID 20210311033323.191873-1-hoang.h.le@dektech.com.au
State New
Headers show
Series [net-next,1/2] tipc: convert dest node's address to network order | expand

Commit Message

Hoang Le March 11, 2021, 3:33 a.m. UTC 
From: Hoang Le <hoang.h.le@dektech.com.au>

(struct tipc_link_info)->dest is in network order (__be32), so we must
convert the value to network order before assigning. The problem detected
by sparse:

net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)
net/tipc/netlink_compat.c:699:24:    expected restricted __be32 [usertype] dest
net/tipc/netlink_compat.c:699:24:    got int

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
---
 net/tipc/netlink_compat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 12, 2021, 2:10 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 11 Mar 2021 10:33:22 +0700 you wrote:
> From: Hoang Le <hoang.h.le@dektech.com.au>

> 

> (struct tipc_link_info)->dest is in network order (__be32), so we must

> convert the value to network order before assigning. The problem detected

> by sparse:

> 

> net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)

> net/tipc/netlink_compat.c:699:24:    expected restricted __be32 [usertype] dest

> net/tipc/netlink_compat.c:699:24:    got int

> 

> [...]


Here is the summary with links:
  - [net-next,1/2] tipc: convert dest node's address to network order
    https://git.kernel.org/netdev/net-next/c/1980d3756506
  - [net-next,2/2] tipc: clean up warnings detected by sparse
    https://git.kernel.org/netdev/net-next/c/97bc84bbd4de

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index 5a1ce64039f7..0749df80454d 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -696,7 +696,7 @@  static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg,
 	if (err)
 		return err;
 
-	link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
+	link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST]));
 	link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
 	nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME],
 		    TIPC_MAX_LINK_NAME);