Message ID | 20210423113944.42672-22-hare@suse.de |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C1EC433B4 for <linux-scsi@archiver.kernel.org>; Fri, 23 Apr 2021 11:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E69B61139 for <linux-scsi@archiver.kernel.org>; Fri, 23 Apr 2021 11:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242345AbhDWLkx (ORCPT <rfc822;linux-scsi@archiver.kernel.org>); Fri, 23 Apr 2021 07:40:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:46930 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242249AbhDWLkj (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Fri, 23 Apr 2021 07:40:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77D96B1CA; Fri, 23 Apr 2021 11:39:55 +0000 (UTC) From: Hannes Reinecke <hare@suse.de> To: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de>, James Bottomley <james.bottomley@hansenpartnership.com>, linux-scsi@vger.kernel.org, Bart van Assche <bvanassche@acm.org>, Hannes Reinecke <hare@suse.de> Subject: [PATCH 21/39] qlogicfas408: translate message to host byte status Date: Fri, 23 Apr 2021 13:39:26 +0200 Message-Id: <20210423113944.42672-22-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210423113944.42672-1-hare@suse.de> References: <20210423113944.42672-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org |
Series |
SCSI result cleanup, part 2
|
expand
|
diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c index 86de400ca81a..aca76106f111 100644 --- a/drivers/scsi/qlogicfas408.c +++ b/drivers/scsi/qlogicfas408.c @@ -409,7 +409,8 @@ static void ql_pcmd(struct scsi_cmnd *cmd) } set_host_byte(cmd, result); - set_msg_byte(cmd, message); + if (result == DID_OK && message != COMMAND_COMPLETE) + translate_msg_byte(cmd, message); set_status_byte(cmd, status); return; }
Instead of setting the message byte translate it to the appropriate host byte. As error recovery would return DID_ERROR for any non-zero message byte the translation doesn't change the error handling. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/qlogicfas408.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)