diff mbox series

[v2,2/2] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster

Message ID 20210426221446.1852572-3-bryan.odonoghue@linaro.org
State New
Headers show
Series Enable VBUS current boost on pm8150b platforms | expand

Commit Message

Bryan O'Donoghue April 26, 2021, 10:14 p.m. UTC 
From: Wesley Cheng <wcheng@codeaurora.org>

Add the required DTS node for the USB VBUS output regulator, which is
available on PM8150B.  This will provide the VBUS source to connected
peripherals.

bod: Add minimum and maximum amperage values for the VBUS current provided
     by the pm8150b.

Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Mark Brown April 27, 2021, 11:27 a.m. UTC | #1 
On Mon, Apr 26, 2021 at 11:14:46PM +0100, Bryan O'Donoghue wrote:

> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi

> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi

> @@ -53,6 +53,14 @@ power-on@800 {

>  			status = "disabled";

>  		};

>  

> +		pm8150b_vbus: dcdc@1100 {

> +			compatible = "qcom,pm8150b-vbus-reg";

> +			regulator-min-microamp = <500000>;

> +			regulator-max-microamp = <3000000>;

> +			status = "disabled";

> +			reg = <0x1100>;

> +		};


This appears to be a generic .dtsi for any system with this device, it's
very much not idiomatic to be setting regulator constraints that allow
things to be changed like this by default (even though the board does
need to explicitly opt in to having the device).
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
index b21e56a46145b..2a90d773810ad 100644
--- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
@@ -53,6 +53,14 @@  power-on@800 {
 			status = "disabled";
 		};
 
+		pm8150b_vbus: dcdc@1100 {
+			compatible = "qcom,pm8150b-vbus-reg";
+			regulator-min-microamp = <500000>;
+			regulator-max-microamp = <3000000>;
+			status = "disabled";
+			reg = <0x1100>;
+		};
+
 		pm8150b_temp: temp-alarm@2400 {
 			compatible = "qcom,spmi-temp-alarm";
 			reg = <0x2400>;