| Message ID | 20210511094308.4779-1-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] drm/kmb: Remove redundant error printing in kmb_dsi_map_mmio() | expand |
diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 4b5d82af84b3014..6f278bc018cee67 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -1468,10 +1468,8 @@ int kmb_dsi_map_mmio(struct kmb_dsi *kmb_dsi) return -ENOMEM; } kmb_dsi->mipi_mmio = devm_ioremap_resource(dev, res); - if (IS_ERR(kmb_dsi->mipi_mmio)) { - dev_err(dev, "failed to ioremap mipi registers"); + if (IS_ERR(kmb_dsi->mipi_mmio)) return PTR_ERR(kmb_dsi->mipi_mmio); - } return 0; }
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/gpu/drm/kmb/kmb_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd