| Message ID | 20210514192218.13022-13-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add new Renesas RZ/G2L SoC and Renesas RZ/G2L SMARC EVK support | expand |
Hi Prabhakar, Thanks for your patch! On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Define RZ/G2L (R9A07G044) Clock Pulse Generator Core Clock (see Table 8.5 ("Clock List")) > and module clock outputs. > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > include/dt-bindings/clock/r9a07g044l-cpg.h | 89 ++++++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 include/dt-bindings/clock/r9a07g044l-cpg.h > > diff --git a/include/dt-bindings/clock/r9a07g044l-cpg.h b/include/dt-bindings/clock/r9a07g044l-cpg.h > new file mode 100644 > index 000000000000..2bc13f4e575b > --- /dev/null > +++ b/include/dt-bindings/clock/r9a07g044l-cpg.h > @@ -0,0 +1,89 @@ > +/* SPDX-License-Identifier: GPL-2.0 > + * > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > +#ifndef __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ > +#define __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ > + > +#include <dt-bindings/clock/renesas-cpg-mssr.h> > + > +/* R9A07G044 CPG Core Clocks */ > +#define R9A07G044_CLK_I 0 > +#define R9A07G044_CLK_I2 1 > +#define R9A07G044_CLK_G 2 > +#define R9A07G044_CLK_S0 3 > +#define R9A07G044_CLK_S1 4 > +#define R9A07G044_CLK_SPI0 5 > +#define R9A07G044_CLK_SPI1 6 > +#define R9A07G044_CLK_SD0 7 > +#define R9A07G044_CLK_SD1 8 > +#define R9A07G044_CLK_M0 9 > +#define R9A07G044_CLK_M1 10 > +#define R9A07G044_CLK_M2 11 > +#define R9A07G044_CLK_M3 12 > +#define R9A07G044_CLK_M4 13 > +#define R9A07G044_CLK_HP 14 > +#define R9A07G044_CLK_TSU 15 > +#define R9A07G044_CLK_ZT 16 > +#define R9A07G044_CLK_P0 17 > +#define R9A07G044_CLK_P1 18 > +#define R9A07G044_CLK_P2 19 > +#define R9A07G044_CLK_AT 20 > +#define R9A07G044_OSCCLK 21 Looks good to me. > + > +/* R9A07G044 Module Clocks */ > +#define R9A07G044_CLK_GIC600 0 > +#define R9A07G044_CLK_IA55 1 > +#define R9A07G044_CLK_SYC 2 > +#define R9A07G044_CLK_DMAC 3 > +#define R9A07G044_CLK_SYSC 4 > +#define R9A07G044_CLK_MTU 5 > +#define R9A07G044_CLK_GPT 6 > +#define R9A07G044_CLK_ETH0 7 > +#define R9A07G044_CLK_ETH1 8 > +#define R9A07G044_CLK_I2C0 9 > +#define R9A07G044_CLK_I2C1 10 > +#define R9A07G044_CLK_I2C2 11 > +#define R9A07G044_CLK_I2C3 12 > +#define R9A07G044_CLK_SCIF0 13 > +#define R9A07G044_CLK_SCIF1 14 > +#define R9A07G044_CLK_SCIF2 15 > +#define R9A07G044_CLK_SCIF3 16 > +#define R9A07G044_CLK_SCIF4 17 > +#define R9A07G044_CLK_SCI0 18 > +#define R9A07G044_CLK_SCI1 19 > +#define R9A07G044_CLK_GPIO 20 > +#define R9A07G044_CLK_SDHI0 21 > +#define R9A07G044_CLK_SDHI1 22 > +#define R9A07G044_CLK_USB0 23 > +#define R9A07G044_CLK_USB1 24 > +#define R9A07G044_CLK_CANFD 25 > +#define R9A07G044_CLK_SSI0 26 > +#define R9A07G044_CLK_SSI1 27 > +#define R9A07G044_CLK_SSI2 28 > +#define R9A07G044_CLK_SSI3 29 > +#define R9A07G044_CLK_MHU 30 > +#define R9A07G044_CLK_OSTM0 31 > +#define R9A07G044_CLK_OSTM1 32 > +#define R9A07G044_CLK_OSTM2 33 > +#define R9A07G044_CLK_WDT0 34 > +#define R9A07G044_CLK_WDT1 35 > +#define R9A07G044_CLK_WDT2 36 > +#define R9A07G044_CLK_WDT_PON 37 > +#define R9A07G044_CLK_GPU 38 > +#define R9A07G044_CLK_ISU 39 > +#define R9A07G044_CLK_H264 40 > +#define R9A07G044_CLK_CRU 41 > +#define R9A07G044_CLK_MIPI_DSI 42 > +#define R9A07G044_CLK_LCDC 43 > +#define R9A07G044_CLK_SRC 44 > +#define R9A07G044_CLK_RSPI0 45 > +#define R9A07G044_CLK_RSPI1 46 > +#define R9A07G044_CLK_RSPI2 47 > +#define R9A07G044_CLK_ADC 48 > +#define R9A07G044_CLK_TSU_PCLK 49 > +#define R9A07G044_CLK_SPI 50 > +#define R9A07G044_CLK_MIPI_DSI_V 51 > +#define R9A07G044_CLK_MIPI_DSI_PIN 52 Are these also listed in the Hardware User's Manual? Or is this your own list? > + > +#endif /* __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Prabhakar, On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Define RZ/G2L (R9A07G044) Clock Pulse Generator Core Clock > and module clock outputs. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > include/dt-bindings/clock/r9a07g044l-cpg.h | 89 ++++++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 include/dt-bindings/clock/r9a07g044l-cpg.h > > diff --git a/include/dt-bindings/clock/r9a07g044l-cpg.h b/include/dt-bindings/clock/r9a07g044l-cpg.h > new file mode 100644 > index 000000000000..2bc13f4e575b > --- /dev/null > +++ b/include/dt-bindings/clock/r9a07g044l-cpg.h I think the filename should be r9a07g044-cpg.h, as this is shared by RZ/G2L ('044l) and RZ/G2LC ('044c). > @@ -0,0 +1,89 @@ > +/* SPDX-License-Identifier: GPL-2.0 > + * > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > +#ifndef __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ > +#define __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ The include guards are fine ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Fri, May 21, 2021 at 4:19 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Define RZ/G2L (R9A07G044) Clock Pulse Generator Core Clock > > and module clock outputs. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > include/dt-bindings/clock/r9a07g044l-cpg.h | 89 ++++++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 include/dt-bindings/clock/r9a07g044l-cpg.h > > > > diff --git a/include/dt-bindings/clock/r9a07g044l-cpg.h b/include/dt-bindings/clock/r9a07g044l-cpg.h > > new file mode 100644 > > index 000000000000..2bc13f4e575b > > --- /dev/null > > +++ b/include/dt-bindings/clock/r9a07g044l-cpg.h > > I think the filename should be r9a07g044-cpg.h, as this is > shared by RZ/G2L ('044l) and RZ/G2LC ('044c). > Agreed will rename that. Cheers, Prabhakar > > @@ -0,0 +1,89 @@ > > +/* SPDX-License-Identifier: GPL-2.0 > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > +#ifndef __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ > > +#define __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ > > The include guards are fine ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/include/dt-bindings/clock/r9a07g044l-cpg.h b/include/dt-bindings/clock/r9a07g044l-cpg.h new file mode 100644 index 000000000000..2bc13f4e575b --- /dev/null +++ b/include/dt-bindings/clock/r9a07g044l-cpg.h @@ -0,0 +1,89 @@ +/* SPDX-License-Identifier: GPL-2.0 + * + * Copyright (C) 2021 Renesas Electronics Corp. + */ +#ifndef __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ +#define __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ + +#include <dt-bindings/clock/renesas-cpg-mssr.h> + +/* R9A07G044 CPG Core Clocks */ +#define R9A07G044_CLK_I 0 +#define R9A07G044_CLK_I2 1 +#define R9A07G044_CLK_G 2 +#define R9A07G044_CLK_S0 3 +#define R9A07G044_CLK_S1 4 +#define R9A07G044_CLK_SPI0 5 +#define R9A07G044_CLK_SPI1 6 +#define R9A07G044_CLK_SD0 7 +#define R9A07G044_CLK_SD1 8 +#define R9A07G044_CLK_M0 9 +#define R9A07G044_CLK_M1 10 +#define R9A07G044_CLK_M2 11 +#define R9A07G044_CLK_M3 12 +#define R9A07G044_CLK_M4 13 +#define R9A07G044_CLK_HP 14 +#define R9A07G044_CLK_TSU 15 +#define R9A07G044_CLK_ZT 16 +#define R9A07G044_CLK_P0 17 +#define R9A07G044_CLK_P1 18 +#define R9A07G044_CLK_P2 19 +#define R9A07G044_CLK_AT 20 +#define R9A07G044_OSCCLK 21 + +/* R9A07G044 Module Clocks */ +#define R9A07G044_CLK_GIC600 0 +#define R9A07G044_CLK_IA55 1 +#define R9A07G044_CLK_SYC 2 +#define R9A07G044_CLK_DMAC 3 +#define R9A07G044_CLK_SYSC 4 +#define R9A07G044_CLK_MTU 5 +#define R9A07G044_CLK_GPT 6 +#define R9A07G044_CLK_ETH0 7 +#define R9A07G044_CLK_ETH1 8 +#define R9A07G044_CLK_I2C0 9 +#define R9A07G044_CLK_I2C1 10 +#define R9A07G044_CLK_I2C2 11 +#define R9A07G044_CLK_I2C3 12 +#define R9A07G044_CLK_SCIF0 13 +#define R9A07G044_CLK_SCIF1 14 +#define R9A07G044_CLK_SCIF2 15 +#define R9A07G044_CLK_SCIF3 16 +#define R9A07G044_CLK_SCIF4 17 +#define R9A07G044_CLK_SCI0 18 +#define R9A07G044_CLK_SCI1 19 +#define R9A07G044_CLK_GPIO 20 +#define R9A07G044_CLK_SDHI0 21 +#define R9A07G044_CLK_SDHI1 22 +#define R9A07G044_CLK_USB0 23 +#define R9A07G044_CLK_USB1 24 +#define R9A07G044_CLK_CANFD 25 +#define R9A07G044_CLK_SSI0 26 +#define R9A07G044_CLK_SSI1 27 +#define R9A07G044_CLK_SSI2 28 +#define R9A07G044_CLK_SSI3 29 +#define R9A07G044_CLK_MHU 30 +#define R9A07G044_CLK_OSTM0 31 +#define R9A07G044_CLK_OSTM1 32 +#define R9A07G044_CLK_OSTM2 33 +#define R9A07G044_CLK_WDT0 34 +#define R9A07G044_CLK_WDT1 35 +#define R9A07G044_CLK_WDT2 36 +#define R9A07G044_CLK_WDT_PON 37 +#define R9A07G044_CLK_GPU 38 +#define R9A07G044_CLK_ISU 39 +#define R9A07G044_CLK_H264 40 +#define R9A07G044_CLK_CRU 41 +#define R9A07G044_CLK_MIPI_DSI 42 +#define R9A07G044_CLK_LCDC 43 +#define R9A07G044_CLK_SRC 44 +#define R9A07G044_CLK_RSPI0 45 +#define R9A07G044_CLK_RSPI1 46 +#define R9A07G044_CLK_RSPI2 47 +#define R9A07G044_CLK_ADC 48 +#define R9A07G044_CLK_TSU_PCLK 49 +#define R9A07G044_CLK_SPI 50 +#define R9A07G044_CLK_MIPI_DSI_V 51 +#define R9A07G044_CLK_MIPI_DSI_PIN 52 + +#endif /* __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ */