| Message ID | 20230530173000.3060865-14-dave.stevenson@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | c546429a60c8802723f36171e13cb53ca14ebae0 |
| Headers | show |
| Series | [01/21] media: i2c: imx258: Remove unused defines | expand |
On Tue, May 30, 2023 at 06:29:52PM +0100, Dave Stevenson wrote: > The data sheet states that the maximum value for registers > 0x0340/0x0341 FRM_LENGTH_LINES is 65525(decimal), not the > 0xFFFF defined in this driver. Correct this limit. It was close indeed :) Good catch Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/media/i2c/imx258.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > index b5c2dcb7c9e6..f5199e3243e8 100644 > --- a/drivers/media/i2c/imx258.c > +++ b/drivers/media/i2c/imx258.c > @@ -28,7 +28,7 @@ > #define IMX258_VTS_30FPS 0x0c50 > #define IMX258_VTS_30FPS_2K 0x0638 > #define IMX258_VTS_30FPS_VGA 0x034c > -#define IMX258_VTS_MAX 0xffff > +#define IMX258_VTS_MAX 65525 > > #define IMX258_REG_VTS 0x0340 > > -- > 2.25.1 >
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index b5c2dcb7c9e6..f5199e3243e8 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -28,7 +28,7 @@ #define IMX258_VTS_30FPS 0x0c50 #define IMX258_VTS_30FPS_2K 0x0638 #define IMX258_VTS_30FPS_VGA 0x034c -#define IMX258_VTS_MAX 0xffff +#define IMX258_VTS_MAX 65525 #define IMX258_REG_VTS 0x0340
The data sheet states that the maximum value for registers 0x0340/0x0341 FRM_LENGTH_LINES is 65525(decimal), not the 0xFFFF defined in this driver. Correct this limit. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- drivers/media/i2c/imx258.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)