| Message ID | 1621937466-1502-7-git-send-email-skakit@codeaurora.org |
|---|---|
| State | Accepted |
| Commit | f878e1baa4ae8211982022bde8f2ad06acbd234d |
| Headers | show |
| Series | Add PMIC DT files for sc7280 | expand |
On Tue, May 25, 2021 at 03:41:01PM +0530, satya priya wrote: > Add gpio ranges and correct the compatible to add > "qcom,spmi-gpio" as this pmic is on spmi bus. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V5: > - This is split from patch [5/11] and added newly in V5. actually it's a split from patch [5/8], right? https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-6-git-send-email-skakit@codeaurora.org/ > arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi > index b0a7cd6c0..b4b6ba24 100644 > --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi > @@ -21,9 +21,10 @@ > }; > > pmr735a_gpios: gpio@8800 { > - compatible = "qcom,pmr735a-gpio"; > + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio"; > reg = <0x8800>; > gpio-controller; > + gpio-ranges = <&pmr735a_gpios 0 0 4>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On 2021-05-26 02:26, Matthias Kaehlcke wrote: > On Tue, May 25, 2021 at 03:41:01PM +0530, satya priya wrote: >> Add gpio ranges and correct the compatible to add >> "qcom,spmi-gpio" as this pmic is on spmi bus. >> >> Signed-off-by: satya priya <skakit@codeaurora.org> >> --- >> Changes in V5: >> - This is split from patch [5/11] and added newly in V5. > > actually it's a split from patch [5/8], right? > Right, my bad. I should have mentioned this way to be more clear. Thank you for reviewing the patches! > https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-6-git-send-email-skakit@codeaurora.org/ > >> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi >> b/arch/arm64/boot/dts/qcom/pmr735a.dtsi >> index b0a7cd6c0..b4b6ba24 100644 >> --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi >> @@ -21,9 +21,10 @@ >> }; >> >> pmr735a_gpios: gpio@8800 { >> - compatible = "qcom,pmr735a-gpio"; >> + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio"; >> reg = <0x8800>; >> gpio-controller; >> + gpio-ranges = <&pmr735a_gpios 0 0 4>; >> #gpio-cells = <2>; >> interrupt-controller; >> #interrupt-cells = <2>; > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi index b0a7cd6c0..b4b6ba24 100644 --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi @@ -21,9 +21,10 @@ }; pmr735a_gpios: gpio@8800 { - compatible = "qcom,pmr735a-gpio"; + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio"; reg = <0x8800>; gpio-controller; + gpio-ranges = <&pmr735a_gpios 0 0 4>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>;
Add gpio ranges and correct the compatible to add "qcom,spmi-gpio" as this pmic is on spmi bus. Signed-off-by: satya priya <skakit@codeaurora.org> --- Changes in V5: - This is split from patch [5/11] and added newly in V5. arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)