mbox series

[v6,0/7] Introducing an attribute to select the time setting

Message ID 1630147859-17031-1-git-send-email-kewei.xu@mediatek.com
Headers show
Series Introducing an attribute to select the time setting | expand

Message

Kewei Xu Aug. 28, 2021, 10:50 a.m. UTC
v6:
Add the judgment condition, clear the handshake signal between dma and
i2c when multiple msgs are transmitted.

v5:
1. Replace the previous variable name "default_timing_adjust" with "use-default-timing"
2. Added waiting for dma reset mechanism
3. Remove received patch(dt-bindings: i2c: update bindings for MT8195 SOC)

v4:
1. Remove the repeated assignment of the inter_clk_div parameter
2. Modify the wrong assignment of OFFSET_MULTI_DMA
3. Unify the log print format of the i2c_dump_register() and drop the extra outer parentheses
4. Place the fixes at the very least
5. Add fixed tags 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
6. Add "i2c: mediatek: modify bus speed calculation formula"
7. Fix single line characters exceeding 80 characters
8. Combine two different series of patches.

v3:
1. Fix code errors caused by v2 modification

v2:
1. Add "dt-bindings: i2c: add attribute default-timing-adjust"
2. Split the fix into sepatate patch.

Kewei Xu (7):
  i2c: mediatek: fixing the incorrect register offset
  i2c: mediatek: Reset the handshake signal between i2c and dma
  i2c: mediatek: Dump i2c/dma register when a timeout occurs
  dt-bindings: i2c: add attribute use-default-timing
  i2c: mediatek: Add OFFSET_EXT_CONF setting back
  i2c: mediatek: Isolate speed setting via dts for special devices
  i2c: mediatek: modify bus speed calculation formula

 .../devicetree/bindings/i2c/i2c-mt65xx.txt    |   2 +
 drivers/i2c/busses/i2c-mt65xx.c               | 207 ++++++++++++++++--
 2 files changed, 192 insertions(+), 17 deletions(-)

Comments

Qii Wang (王琪) Aug. 31, 2021, 5:57 a.m. UTC | #1
On Sat, 2021-08-28 at 18:50 +0800, Kewei Xu wrote:
> The reason for the modification here is that the previous

> offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is

> the correct value.

> 

> Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")

> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

> ---

>  drivers/i2c/busses/i2c-mt65xx.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 


Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Qii Wang (王琪) Sept. 1, 2021, 9:35 a.m. UTC | #2
On Sat, 2021-08-28 at 18:50 +0800, Kewei Xu wrote:
> When clock-div is 0 or greater than 1, the bus speed

> calculated by the old speed calculation formula will be

> larger than the target speed. So we update the formula.

> 

> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

> ---

>  drivers/i2c/busses/i2c-mt65xx.c | 35 +++++++++++++++++++++++++----------

>  1 file changed, 25 insertions(+), 10 deletions(-)

> 


Reviewed-by: Qii Wang <qii.wang@mediatek.com>