mbox series

[v2,00/15] dra7: mmc: Update mmc dt node

Message ID 20180206125806.19350-1-kishon@ti.com
Headers show
Series dra7: mmc: Update mmc dt node | expand

Message

Kishon Vijay Abraham I Feb. 6, 2018, 12:57 p.m. UTC 
The previous version of the patch series was sent with subject
ARM: dra7/k2g: Use sdhci-omap for MMC/SD controller

This series
  *) Adds missing vqmmc-supply property
  *) Adds pinctrl data (including IOdelay) for dra76
  *) Updates pinctrl data (to select pull down for mmc1_clk) on some of the
     platforms
  *) Uses sdhci-omap programming model (depends on [1])

Changes from v1:
  *) Avoid defining duplicate pinctrl groups.
  *) Remove keystone specific patches
  *) Add vqmmc-supply and remove mm specific pinmux in dra7-evm

"ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node" patch
can be merged only after [1]. Other patches don't have dependency.

The defconfig patches should be merged before
"ARM: dts: dra7: Use sdhci-omap programming model"

[1] -> https://lkml.org/lkml/2018/2/5/230

Kishon Vijay Abraham I (11):
  ARM: multi_v7_defconfig: Enable CONFIG_MMC_SDHCI_OMAP
  ARM: omap2plus_defconfig: Enable CONFIG_MMC_SDHCI_OMAP
  ARM: dts: am57xx-beagle-x15: Add "vqmmc-supply" property for mmc2
  ARM: dts: dra7-evm: Remove mmc specific pinmux
  ARM: dts: dra7-evm: Add "vqmmc-supply" property for mmc2
  ARM: dts: am57xx-idk: Add "vqmmc-supply" property for mmc2
  ARM: dts: dra76-evm: Add "vqmmc-supply" property for mmc2
  ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default
    mode
  ARM: dts: am57xx-idk: Select pull down for mmc1_clk line in default
    mode
  ARM: dts: dra7: Use sdhci-omap programming model
  ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node

Ravikumar Kattekola (1):
  ARM: dts: dra71-evm: Correct evm_sd regulator max voltage

Sekhar Nori (3):
  ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data
  ARM: dts: dra76-evm: Shift to using common IOdelay data
  ARM: dts: dra76-evm: Add pinctrl data for higher speed MMC/SD modes

 arch/arm/boot/dts/am571x-idk.dts                |   2 +-
 arch/arm/boot/dts/am572x-idk.dts                |   3 +-
 arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi |   4 +-
 arch/arm/boot/dts/am57xx-idk-common.dtsi        |  14 +-
 arch/arm/boot/dts/dra7-evm.dts                  |  29 +--
 arch/arm/boot/dts/dra7.dtsi                     |  25 ++-
 arch/arm/boot/dts/dra71-evm.dts                 |  17 +-
 arch/arm/boot/dts/dra72-evm-common.dtsi         |   2 +-
 arch/arm/boot/dts/dra76-evm.dts                 |  53 +----
 arch/arm/boot/dts/dra76x-mmc-iodelay.dtsi       | 285 ++++++++++++++++++++++++
 arch/arm/configs/multi_v7_defconfig             |   1 +
 arch/arm/configs/omap2plus_defconfig            |   3 +
 12 files changed, 350 insertions(+), 88 deletions(-)
 create mode 100644 arch/arm/boot/dts/dra76x-mmc-iodelay.dtsi

-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sekhar Nori Feb. 7, 2018, 9:27 a.m. UTC | #1 
On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote:
> Hi,

> 

> On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:

>> Kishon,

>>

>> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:

>>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.

>>>

>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

>>

>> Along with this, dont we need to have

>>

>> 	/delete-property/ mmc-hs200-1_8v;

>>

>> for eMMC on Beagle x15 which does not support HS200?

>>

>> Or are you planning to depend on lack of pinctrl entries for HS200 to

>> take care of that?

> 

> right now it relies on lack of pinctrl entries but I think adding delete

> property is appropriate. Actually I missed porting the patch that adds

> /delete-property/.


Alright, thanks!

Regards,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sekhar Nori Feb. 13, 2018, 11:10 a.m. UTC | #2 
On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote:
> Hi,

> 

> On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:

>> Kishon,

>>

>> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:

>>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.

>>>

>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

>>

>> Along with this, dont we need to have

>>

>> 	/delete-property/ mmc-hs200-1_8v;

>>

>> for eMMC on Beagle x15 which does not support HS200?

>>

>> Or are you planning to depend on lack of pinctrl entries for HS200 to

>> take care of that?

> 

> right now it relies on lack of pinctrl entries but I think adding delete

> property is appropriate. Actually I missed porting the patch that adds

> /delete-property/.


Actually, thinking more, this should be probably be handled using
"no-1-8-v" property. Reading the comment above SDHCI_QUIRK2_NO_1_8_V, it
is specifically meant for the case when system (board) does not support
1.8V even when host (controller) does. Which is exactly the case with
Beagle x15.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kishon Vijay Abraham I March 1, 2018, 5:18 a.m. UTC | #3 
Hi Tony,

On Thursday 01 March 2018 04:04 AM, Tony Lindgren wrote:
> * Sekhar Nori <nsekhar@ti.com> [180213 11:11]:

>> On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote:

>>> Hi,

>>>

>>> On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:

>>>> Kishon,

>>>>

>>>> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:

>>>>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.

>>>>>

>>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

>>>>

>>>> Along with this, dont we need to have

>>>>

>>>> 	/delete-property/ mmc-hs200-1_8v;

>>>>

>>>> for eMMC on Beagle x15 which does not support HS200?

>>>>

>>>> Or are you planning to depend on lack of pinctrl entries for HS200 to

>>>> take care of that?

>>>

>>> right now it relies on lack of pinctrl entries but I think adding delete

>>> property is appropriate. Actually I missed porting the patch that adds

>>> /delete-property/.

>>

>> Actually, thinking more, this should be probably be handled using

>> "no-1-8-v" property. Reading the comment above SDHCI_QUIRK2_NO_1_8_V, it

>> is specifically meant for the case when system (board) does not support

>> 1.8V even when host (controller) does. Which is exactly the case with

>> Beagle x15.

> 

> OK so that seems to be related to the last patch. I've applied

> the first two defconfig patches into omap-for-v4.17/defconfig

> and patches up to patch 13/15 into omap-for-v4.17/dt-sdhci.

> 

> Kishon, please repost the missing changes or ping me when

> the driver dependencies have cleared for further patches to

> be applied to enable sdhci.


sure, I'll repost when sdhci driver changes gets merged.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html