mbox series

[v8,00/11] arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs

Message ID 20230526192210.3146896-1-bhupesh.sharma@linaro.org
Headers show
Series arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand

Message

Bhupesh Sharma May 26, 2023, 7:21 p.m. UTC
Changes since v7:
-----------------
- v7 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230519214813.2593271-1-bhupesh.sharma@linaro.org/
- Addressed Stephan's comment about RPM clocks for sm6115 crypto block in dtsi.
- Also fixed the iommu context ids for sm6115 crypto block in dtsi.

Changes since v6:
-----------------
- v6 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230405072836.1690248-1-bhupesh.sharma@linaro.org/
- Collected Acks, R-Bs and Tested-by for various patches.
- Addressed Konrad's comment about iommu sids for sm8150 and sm8250
  crypto node entries.
- Addressed Konrad's and Stephan's comments about adding RPM clock for
  crypto blocks on qcm2290 and sm6115.

Changes since v5:
-----------------
- v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230402100509.1154220-1-bhupesh.sharma@linaro.org/
- Collected Ack from Rob for [PATCH 01/11].
- Addressed Georgi's comment about interconnect cells in [PATCH 10/11].

Changes since v4:
-----------------
- v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230331164323.729093-1-bhupesh.sharma@linaro.org/
- Collected R-Bs from Konrad for a couple of patches sent in v4.
- Fixed incorrect email IDs for a couple of patches sent in v3, which I used for
  some patches created on a different work machine.
- No functional changes since v3.

Changes since v3:
-----------------
- v3 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230328092815.292665-1-bhupesh.sharma@linaro.org/
- Collected Acks from Krzysztof for a couple of patches sent in v3.
- Fixed review comments from Krzysztof regarding DMA binding document
  and also added a couple of new patches which are required to fix the
  'dtbs_check' errors highlighted after this fix.

Changes since v2:
-----------------
- v2 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230322114519.3412469-1-bhupesh.sharma@linaro.org/
- No functional change since v2. As the sdm845 patch from v1 was accepted in linux-next,
  dropped it from this version.

Changes since v1:
-----------------
- v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230321190118.3327360-1-bhupesh.sharma@linaro.org/
- Folded the BAM DMA dt-binding change.
  (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/)
- Folded the QCE dt-binding change.
  (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230320073816.3012198-1-bhupesh.sharma@linaro.org/)
- Folded Neil's SM8450 dts patch in this series.
- Addressed review comments from Rob, Stephan and Konrad.
- Collected Konrad's R-B for [PATCH 5/9].

This patchset enables Crypto Engine support for Qualcomm SoCs like
SM6115, SM8150, SM8250, SM8350 and SM8450.

Note that:
- SM8250 crypto engine patch utilizes the work already done by myself and
  Vladimir.
- SM8350 crypto engine patch utilizes the work already done by Robert.
- SM8450 crypto engine patch utilizes the work already done by Neil.

Also this patchset is rebased on linux-next/master.



Bhupesh Sharma (10):
  dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs
  dt-bindings: dma: Increase iommu maxItems for BAM DMA
  arm64: dts: qcom: sdm8550: Fix the BAM DMA engine compatible string
  arm64: dts: qcom: sdm845: Fix the slimbam DMA engine compatible string
  dt-bindings: qcom-qce: Fix compatible combinations for SM8150 and
    IPQ4019 SoCs
  dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290
  arm64: dts: qcom: sm6115: Add Crypto Engine support
  arm64: dts: qcom: sm8150: Add Crypto Engine support
  arm64: dts: qcom: sm8250: Add Crypto Engine support
  arm64: dts: qcom: sm8350: Add Crypto Engine support

Neil Armstrong (1):
  arm64: dts: qcom: sm8450: add crypto nodes

 .../devicetree/bindings/crypto/qcom-qce.yaml  | 50 +++++++++++++++----
 .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++---
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |  2 +-
 arch/arm64/boot/dts/qcom/sm6115.dtsi          | 31 ++++++++++++
 arch/arm64/boot/dts/qcom/sm8150.dtsi          | 30 +++++++++++
 arch/arm64/boot/dts/qcom/sm8250.dtsi          | 32 ++++++++++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi          | 22 ++++++++
 arch/arm64/boot/dts/qcom/sm8450.dtsi          | 28 +++++++++++
 arch/arm64/boot/dts/qcom/sm8550.dtsi          |  2 +-
 9 files changed, 200 insertions(+), 19 deletions(-)

Comments

Herbert Xu June 2, 2023, 10:26 a.m. UTC | #1
On Mon, May 29, 2023 at 11:45:54AM +0530, Bhupesh Sharma wrote:
>
> Bjorn has applied the dts patches from this series to his tree.
> As suggested by him, can you please pick patches [PATCH 5/11] and
> [PATCH 6/11] from this series via the 'crypto' tree.

OK I've applied patches 5 and 6.

Thanks,
Bhupesh Sharma June 30, 2023, 8:30 a.m. UTC | #2
On 6/8/23 6:02 PM, Vinod Koul wrote:
> On 29-05-23, 11:43, Bhupesh Sharma wrote:
>> Hi Vinod,
>>
>>> On Sat, 27 May 2023 at 00:52, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>>>
>>> Add new compatible for BAM DMA engine version v1.7.4 which is
>>> found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
>>> to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
>>> accordingly.
>>>
>>> While at it, also update qcom,bam-dma bindings to add comments
>>> which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
>>> This provides an easy reference for identifying the actual BAM DMA
>>> version available on Qualcomm SoCs.
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>>> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>>> ---
>>>   .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
>>>   1 file changed, 13 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> index f1ddcf672261..c663b6102f50 100644
>>> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> @@ -15,13 +15,19 @@ allOf:
>>>
>>>   properties:
>>>     compatible:
>>> -    enum:
>>> -        # APQ8064, IPQ8064 and MSM8960
>>> -      - qcom,bam-v1.3.0
>>> -        # MSM8974, APQ8074 and APQ8084
>>> -      - qcom,bam-v1.4.0
>>> -        # MSM8916 and SDM845
>>> -      - qcom,bam-v1.7.0
>>> +    oneOf:
>>> +      - enum:
>>> +          # APQ8064, IPQ8064 and MSM8960
>>> +          - qcom,bam-v1.3.0
>>> +          # MSM8974, APQ8074 and APQ8084
>>> +          - qcom,bam-v1.4.0
>>> +          # MSM8916, SDM630
>>> +          - qcom,bam-v1.7.0
>>> +      - items:
>>> +          - enum:
>>> +              # SDM845, SM6115, SM8150, SM8250 and QCM2290
>>> +              - qcom,bam-v1.7.4
>>> +          - const: qcom,bam-v1.7.0
>>>
>>>     clocks:
>>>       maxItems: 1
>>> --
>>> 2.38.1
>>
>> Bjorn has applied the dts patches from this series to his tree.
>> As suggested by him, can you please pick patches [PATCH 1/11] and
>> [PATCH 2/11] from this series via the 'dmaengine' tree.
> 
> I dont have this series in my inbox or dmaengine pw
> 
>> Seems some Cc fields got messed up while sending the patchset, so
>> Cc'ing the dmaengine list again.
> 
> not just list but mine too..
> 
> Please rebase and resend

Sure, I have sent a v9, which can be seen here: 
<https://lore.kernel.org/linux-arm-msm/20230630082230.2264698-1-bhupesh.sharma@linaro.org/>
Please help review.

Thanks,
Bhupesh