| Message ID | 20231004161038.2818327-8-gregory.clement@bootlin.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for the Mobileye EyeQ5 SoC | expand |
On Wed, Oct 04, 2023 at 06:10:34PM +0200, Gregory CLEMENT wrote: > Document Mobileye EyeQ5 compatibles for OLB registers that are > misceallanous SoC related registers. typo. Please state what OLB is and what kind of things are in this block. IOW, convince me this is not just a skeleton placeholder until you add a bunch of providers in a real binding. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 8103154bbb52..70bc6e8d15ba 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -53,6 +53,7 @@ properties: > - mediatek,mt8135-pctl-a-syscfg > - mediatek,mt8135-pctl-b-syscfg > - mediatek,mt8365-syscfg > + - mobileye,eyeq5-olb > - microchip,lan966x-cpu-syscon > - microchip,sparx5-cpu-syscon > - mstar,msc313-pmsleep > -- > 2.40.1 >
Rob Herring <robh@kernel.org> writes: > On Wed, Oct 04, 2023 at 06:10:34PM +0200, Gregory CLEMENT wrote: >> Document Mobileye EyeQ5 compatibles for OLB registers that are >> misceallanous SoC related registers. > > typo. > > Please state what OLB is and what kind of things are in this block. IOW, > convince me this is not just a skeleton placeholder until you add a > bunch of providers in a real binding. I understand your concern. First OLB stands for Other Logic Block which does not say much about it! It is used to expose SoC specific configuration such as for example reset, clock or pinctrl. We have a few series nearly ready to be send to add support for them, each of them will use this block. So declaring this block since the beginning avoid to have dependencies between these series and they will only depend of this current initial series. Is it OK for you ? Besides fixing the typo I can add the following explanation to the commit log: "It is used to expose SoC specific configuration such as for example reset, clock or pinctrl" Gregory > >> >> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> >> --- >> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml >> index 8103154bbb52..70bc6e8d15ba 100644 >> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml >> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml >> @@ -53,6 +53,7 @@ properties: >> - mediatek,mt8135-pctl-a-syscfg >> - mediatek,mt8135-pctl-b-syscfg >> - mediatek,mt8365-syscfg >> + - mobileye,eyeq5-olb >> - microchip,lan966x-cpu-syscon >> - microchip,sparx5-cpu-syscon >> - mstar,msc313-pmsleep >> -- >> 2.40.1 >>
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 8103154bbb52..70bc6e8d15ba 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -53,6 +53,7 @@ properties: - mediatek,mt8135-pctl-a-syscfg - mediatek,mt8135-pctl-b-syscfg - mediatek,mt8365-syscfg + - mobileye,eyeq5-olb - microchip,lan966x-cpu-syscon - microchip,sparx5-cpu-syscon - mstar,msc313-pmsleep
Document Mobileye EyeQ5 compatibles for OLB registers that are misceallanous SoC related registers. Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> --- Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + 1 file changed, 1 insertion(+)