diff mbox series

[1/3] pinctrl: ingenic: Fix incorrect pull up/down info

Message ID 20210717174836.14776-1-paul@crapouillou.net
State New
Headers show
Series [1/3] pinctrl: ingenic: Fix incorrect pull up/down info | expand

Commit Message

Paul Cercueil July 17, 2021, 5:48 p.m. UTC
Fix the pull up/down info for both the JZ4760 and JZ4770 SoCs, as the
previous values sometimes contradicted what's written in the programming
manual.

Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Cc: <stable@vger.kernel.org> # v4.12
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/pinctrl/pinctrl-ingenic.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

周琰杰 (Zhou Yanjie) July 24, 2021, 6:41 a.m. UTC | #1
Hi Paul,

On 2021/7/18 上午1:48, Paul Cercueil wrote:
> Fix the pull up/down info for both the JZ4760 and JZ4770 SoCs, as the

> previous values sometimes contradicted what's written in the programming

> manual.

>

> Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")

> Cc: <stable@vger.kernel.org> # v4.12

> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

> ---

>   drivers/pinctrl/pinctrl-ingenic.c | 6 +++---

>   1 file changed, 3 insertions(+), 3 deletions(-)



Tested-by: 周琰杰 (Zhou Yanjie)<zhouyanjie@wanyeetech.com>



>

> diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c

> index 983ba9865f77..126ca671c3cd 100644

> --- a/drivers/pinctrl/pinctrl-ingenic.c

> +++ b/drivers/pinctrl/pinctrl-ingenic.c

> @@ -710,7 +710,7 @@ static const struct ingenic_chip_info jz4755_chip_info = {

>   };

>   

>   static const u32 jz4760_pull_ups[6] = {

> -	0xffffffff, 0xfffcf3ff, 0xffffffff, 0xffffcfff, 0xfffffb7c, 0xfffff00f,

> +	0xffffffff, 0xfffcf3ff, 0xffffffff, 0xffffcfff, 0xfffffb7c, 0x0000000f,

>   };

>   

>   static const u32 jz4760_pull_downs[6] = {

> @@ -936,11 +936,11 @@ static const struct ingenic_chip_info jz4760_chip_info = {

>   };

>   

>   static const u32 jz4770_pull_ups[6] = {

> -	0x3fffffff, 0xfff0030c, 0xffffffff, 0xffff4fff, 0xfffffb7c, 0xffa7f00f,

> +	0x3fffffff, 0xfff0f3fc, 0xffffffff, 0xffff4fff, 0xfffffb7c, 0x0024f00f,

>   };

>   

>   static const u32 jz4770_pull_downs[6] = {

> -	0x00000000, 0x000f0c03, 0x00000000, 0x0000b000, 0x00000483, 0x00580ff0,

> +	0x00000000, 0x000f0c03, 0x00000000, 0x0000b000, 0x00000483, 0x005b0ff0,

>   };

>   

>   static int jz4770_uart0_data_pins[] = { 0xa0, 0xa3, };
Linus Walleij Aug. 11, 2021, 8:24 a.m. UTC | #2
On Sat, Jul 17, 2021 at 7:48 PM Paul Cercueil <paul@crapouillou.net> wrote:

> Fix the pull up/down info for both the JZ4760 and JZ4770 SoCs, as the

> previous values sometimes contradicted what's written in the programming

> manual.

>

> Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")

> Cc: <stable@vger.kernel.org> # v4.12

> Signed-off-by: Paul Cercueil <paul@crapouillou.net>


Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index 983ba9865f77..126ca671c3cd 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -710,7 +710,7 @@  static const struct ingenic_chip_info jz4755_chip_info = {
 };
 
 static const u32 jz4760_pull_ups[6] = {
-	0xffffffff, 0xfffcf3ff, 0xffffffff, 0xffffcfff, 0xfffffb7c, 0xfffff00f,
+	0xffffffff, 0xfffcf3ff, 0xffffffff, 0xffffcfff, 0xfffffb7c, 0x0000000f,
 };
 
 static const u32 jz4760_pull_downs[6] = {
@@ -936,11 +936,11 @@  static const struct ingenic_chip_info jz4760_chip_info = {
 };
 
 static const u32 jz4770_pull_ups[6] = {
-	0x3fffffff, 0xfff0030c, 0xffffffff, 0xffff4fff, 0xfffffb7c, 0xffa7f00f,
+	0x3fffffff, 0xfff0f3fc, 0xffffffff, 0xffff4fff, 0xfffffb7c, 0x0024f00f,
 };
 
 static const u32 jz4770_pull_downs[6] = {
-	0x00000000, 0x000f0c03, 0x00000000, 0x0000b000, 0x00000483, 0x00580ff0,
+	0x00000000, 0x000f0c03, 0x00000000, 0x0000b000, 0x00000483, 0x005b0ff0,
 };
 
 static int jz4770_uart0_data_pins[] = { 0xa0, 0xa3, };