diff mbox series

[14/23] gpio: omap: Convert to platform remove callback returning void

Message ID 20230928070706.2290137-15-u.kleine-koenig@pengutronix.de
State New
Headers show
Series [01/23] gpio: altera: Convert to platform remove callback returning void | expand

Commit Message

Uwe Kleine-König Sept. 28, 2023, 7:06 a.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/gpio/gpio-omap.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series


diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index a927680c66f8..8889755e2d03 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1489,7 +1489,7 @@  static int omap_gpio_probe(struct platform_device *pdev)
 	return 0;
-static int omap_gpio_remove(struct platform_device *pdev)
+static void omap_gpio_remove(struct platform_device *pdev)
 	struct gpio_bank *bank = platform_get_drvdata(pdev);
@@ -1498,8 +1498,6 @@  static int omap_gpio_remove(struct platform_device *pdev)
 	if (bank->dbck_flag)
-	return 0;
 static int __maybe_unused omap_gpio_runtime_suspend(struct device *dev)
@@ -1560,7 +1558,7 @@  static const struct dev_pm_ops gpio_pm_ops = {
 static struct platform_driver omap_gpio_driver = {
 	.probe		= omap_gpio_probe,
-	.remove		= omap_gpio_remove,
+	.remove_new	= omap_gpio_remove,
 	.driver		= {
 		.name	= "omap_gpio",
 		.pm	= &gpio_pm_ops,