diff mbox series

[07/23] gpio: grgpio: Convert to platform remove callback returning void

Message ID 20230928070706.2290137-8-u.kleine-koenig@pengutronix.de
State New
Headers show
Series [01/23] gpio: altera: Convert to platform remove callback returning void | expand

Commit Message

Uwe Kleine-König Sept. 28, 2023, 7:06 a.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/gpio/gpio-grgpio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series


diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 0163c95f6dd7..017c7170eb57 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -431,7 +431,7 @@  static int grgpio_probe(struct platform_device *ofdev)
 	return 0;
-static int grgpio_remove(struct platform_device *ofdev)
+static void grgpio_remove(struct platform_device *ofdev)
 	struct grgpio_priv *priv = platform_get_drvdata(ofdev);
@@ -439,8 +439,6 @@  static int grgpio_remove(struct platform_device *ofdev)
 	if (priv->domain)
-	return 0;
 static const struct of_device_id grgpio_match[] = {
@@ -457,7 +455,7 @@  static struct platform_driver grgpio_driver = {
 		.of_match_table = grgpio_match,
 	.probe = grgpio_probe,
-	.remove = grgpio_remove,
+	.remove_new = grgpio_remove,