mbox series

[v3,RESEND,00/20] remove I2C_CLASS_DDC support

Message ID 20231119112826.5115-1-hkallweit1@gmail.com
Headers show
Series remove I2C_CLASS_DDC support | expand

Message

Heiner Kallweit Nov. 19, 2023, 11:28 a.m. UTC
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

v2:
- change tag in commit subject of patch 03
- add ack tags
v3:
- fix a compile error in patch 5

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---

 drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c           |    1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
 drivers/gpu/drm/ast/ast_i2c.c                     |    1 -
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c         |    1 -
 drivers/gpu/drm/display/drm_dp_helper.c           |    1 -
 drivers/gpu/drm/display/drm_dp_mst_topology.c     |    1 -
 drivers/gpu/drm/gma500/cdv_intel_dp.c             |    1 -
 drivers/gpu/drm/gma500/intel_gmbus.c              |    1 -
 drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c        |    1 -
 drivers/gpu/drm/gma500/psb_intel_sdvo.c           |    1 -
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c   |    1 -
 drivers/gpu/drm/i915/display/intel_gmbus.c        |    1 -
 drivers/gpu/drm/i915/display/intel_sdvo.c         |    1 -
 drivers/gpu/drm/loongson/lsdc_i2c.c               |    1 -
 drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c           |    1 -
 drivers/gpu/drm/mgag200/mgag200_i2c.c             |    1 -
 drivers/gpu/drm/msm/hdmi/hdmi_i2c.c               |    1 -
 drivers/gpu/drm/radeon/radeon_i2c.c               |    1 -
 drivers/gpu/drm/rockchip/inno_hdmi.c              |    1 -
 drivers/gpu/drm/rockchip/rk3066_hdmi.c            |    1 -
 drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c            |    1 -
 drivers/video/fbdev/core/fb_ddc.c                 |    1 -
 drivers/video/fbdev/cyber2000fb.c                 |    1 -
 drivers/video/fbdev/i740fb.c                      |    1 -
 drivers/video/fbdev/intelfb/intelfb_i2c.c         |   15 +++++----------
 drivers/video/fbdev/matrox/i2c-matroxfb.c         |   12 ++++--------
 drivers/video/fbdev/s3fb.c                        |    1 -
 drivers/video/fbdev/tdfxfb.c                      |    1 -
 drivers/video/fbdev/tridentfb.c                   |    1 -
 drivers/video/fbdev/via/via_i2c.c                 |    1 -
 include/linux/i2c.h                               |    1 -
 31 files changed, 9 insertions(+), 47 deletions(-)

Comments

Helge Deller Nov. 19, 2023, 8:28 p.m. UTC | #1
On 11/19/23 12:28, Heiner Kallweit wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.

The fbdev changes look at least ok so far, so:
Acked-by: Helge Deller <deller@gmx.de>   #fbdev


> v2:
> - change tag in commit subject of patch 03
> - add ack tags
> v3:
> - fix a compile error in patch 5
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c           |    1 -
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
>   drivers/gpu/drm/ast/ast_i2c.c                     |    1 -
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c         |    1 -
>   drivers/gpu/drm/display/drm_dp_helper.c           |    1 -
>   drivers/gpu/drm/display/drm_dp_mst_topology.c     |    1 -
>   drivers/gpu/drm/gma500/cdv_intel_dp.c             |    1 -
>   drivers/gpu/drm/gma500/intel_gmbus.c              |    1 -
>   drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c        |    1 -
>   drivers/gpu/drm/gma500/psb_intel_sdvo.c           |    1 -
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c   |    1 -
>   drivers/gpu/drm/i915/display/intel_gmbus.c        |    1 -
>   drivers/gpu/drm/i915/display/intel_sdvo.c         |    1 -
>   drivers/gpu/drm/loongson/lsdc_i2c.c               |    1 -
>   drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c           |    1 -
>   drivers/gpu/drm/mgag200/mgag200_i2c.c             |    1 -
>   drivers/gpu/drm/msm/hdmi/hdmi_i2c.c               |    1 -
>   drivers/gpu/drm/radeon/radeon_i2c.c               |    1 -
>   drivers/gpu/drm/rockchip/inno_hdmi.c              |    1 -
>   drivers/gpu/drm/rockchip/rk3066_hdmi.c            |    1 -
>   drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c            |    1 -
>   drivers/video/fbdev/core/fb_ddc.c                 |    1 -
>   drivers/video/fbdev/cyber2000fb.c                 |    1 -
>   drivers/video/fbdev/i740fb.c                      |    1 -
>   drivers/video/fbdev/intelfb/intelfb_i2c.c         |   15 +++++----------
>   drivers/video/fbdev/matrox/i2c-matroxfb.c         |   12 ++++--------
>   drivers/video/fbdev/s3fb.c                        |    1 -
>   drivers/video/fbdev/tdfxfb.c                      |    1 -
>   drivers/video/fbdev/tridentfb.c                   |    1 -
>   drivers/video/fbdev/via/via_i2c.c                 |    1 -
>   include/linux/i2c.h                               |    1 -
>   31 files changed, 9 insertions(+), 47 deletions(-)
>
Heiner Kallweit Nov. 19, 2023, 8:51 p.m. UTC | #2
On 19.11.2023 21:48, Heiner Kallweit wrote:
> On 19.11.2023 21:28, Helge Deller wrote:
>> On 11/19/23 12:28, Heiner Kallweit wrote:
>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>> be used in new code. So we can remove this class completely now.
>>>
>>> Preferably this series should be applied via the i2c tree.
>>
>> The fbdev changes look at least ok so far, so:
>> Acked-by: Helge Deller <deller@gmx.de>   #fbdev
>>
> I think this refers to patch 5 of the series. Could you please reply
> to patch 5 instead of the cover letter with your acked-by so that
> patchwork gets it right? Thanks!
> 
Sorry, just looked at where you are in To, not Cc.
So your ack includes patches 6, 9, 10, 13?

>>
>>> v2:
>>> - change tag in commit subject of patch 03
>>> - add ack tags
>>> v3:
>>> - fix a compile error in patch 5
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> ---
>>>
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c           |    1 -
>>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
>>>   drivers/gpu/drm/ast/ast_i2c.c                     |    1 -
>>>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c         |    1 -
>>>   drivers/gpu/drm/display/drm_dp_helper.c           |    1 -
>>>   drivers/gpu/drm/display/drm_dp_mst_topology.c     |    1 -
>>>   drivers/gpu/drm/gma500/cdv_intel_dp.c             |    1 -
>>>   drivers/gpu/drm/gma500/intel_gmbus.c              |    1 -
>>>   drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c        |    1 -
>>>   drivers/gpu/drm/gma500/psb_intel_sdvo.c           |    1 -
>>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c   |    1 -
>>>   drivers/gpu/drm/i915/display/intel_gmbus.c        |    1 -
>>>   drivers/gpu/drm/i915/display/intel_sdvo.c         |    1 -
>>>   drivers/gpu/drm/loongson/lsdc_i2c.c               |    1 -
>>>   drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c           |    1 -
>>>   drivers/gpu/drm/mgag200/mgag200_i2c.c             |    1 -
>>>   drivers/gpu/drm/msm/hdmi/hdmi_i2c.c               |    1 -
>>>   drivers/gpu/drm/radeon/radeon_i2c.c               |    1 -
>>>   drivers/gpu/drm/rockchip/inno_hdmi.c              |    1 -
>>>   drivers/gpu/drm/rockchip/rk3066_hdmi.c            |    1 -
>>>   drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c            |    1 -
>>>   drivers/video/fbdev/core/fb_ddc.c                 |    1 -
>>>   drivers/video/fbdev/cyber2000fb.c                 |    1 -
>>>   drivers/video/fbdev/i740fb.c                      |    1 -
>>>   drivers/video/fbdev/intelfb/intelfb_i2c.c         |   15 +++++----------
>>>   drivers/video/fbdev/matrox/i2c-matroxfb.c         |   12 ++++--------
>>>   drivers/video/fbdev/s3fb.c                        |    1 -
>>>   drivers/video/fbdev/tdfxfb.c                      |    1 -
>>>   drivers/video/fbdev/tridentfb.c                   |    1 -
>>>   drivers/video/fbdev/via/via_i2c.c                 |    1 -
>>>   include/linux/i2c.h                               |    1 -
>>>   31 files changed, 9 insertions(+), 47 deletions(-)
>>>
>>
>