diff mbox series

[v3,3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

Message ID 20201222070520.710096-3-timon.baetz@protonmail.com
State Superseded
Headers show
Series [v3,1/7] extcon: max8997: Add CHGINS and CHGRM interrupt handling | expand

Commit Message

Timon Baetz Dec. 22, 2020, 7:31 a.m. UTC
Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
of_node set in the extcon driver.

Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
the charger driver.

Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
---
 drivers/mfd/max8997.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones Dec. 22, 2020, 9:55 a.m. UTC | #1
On Tue, 22 Dec 2020, Timon Baetz wrote:

> Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
> of_node set in the extcon driver.
> 
> Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
> the charger driver.
> 
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> ---
>  drivers/mfd/max8997.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.
Timon Baetz Feb. 11, 2021, 9:11 p.m. UTC | #2
On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote:
> On Tue, 22 Dec 2020, Timon Baetz wrote:
> 
> > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a
> > of_node set in the extcon driver.
> >
> > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure
> > the charger driver.
> >
> > Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> > ---
> >  drivers/mfd/max8997.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)  
> 
> Applied, thanks.

Once https://lore.kernel.org/lkml/20210130172747.2022977-1-timon.baetz@protonmail.com/
gets accepted, this is not needed anymore. Can this be reverted or
should I create a new patch?

Thanks,
Timon
Lee Jones Feb. 12, 2021, 9:37 a.m. UTC | #3
On Thu, 11 Feb 2021, Timon Baetz wrote:

> On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote:

> > On Tue, 22 Dec 2020, Timon Baetz wrote:

> > 

> > > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a

> > > of_node set in the extcon driver.

> > >

> > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure

> > > the charger driver.

> > >

> > > Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>

> > > ---

> > >  drivers/mfd/max8997.c | 4 ++--

> > >  1 file changed, 2 insertions(+), 2 deletions(-)  

> > 

> > Applied, thanks.

> 

> Once https://lore.kernel.org/lkml/20210130172747.2022977-1-timon.baetz@protonmail.com/

> gets accepted, this is not needed anymore. Can this be reverted or

> should I create a new patch?


Please submit a revert with the reasons why.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
index 68d8f2b95287..55d3a6f97783 100644
--- a/drivers/mfd/max8997.c
+++ b/drivers/mfd/max8997.c
@@ -29,9 +29,9 @@ 
 static const struct mfd_cell max8997_devs[] = {
 	{ .name = "max8997-pmic", },
 	{ .name = "max8997-rtc", },
-	{ .name = "max8997-battery", },
+	{ .name = "max8997-battery", .of_compatible = "maxim,max8997-battery", },
 	{ .name = "max8997-haptic", },
-	{ .name = "max8997-muic", },
+	{ .name = "max8997-muic", .of_compatible = "maxim,max8997-muic", },
 	{ .name = "max8997-led", .id = 1 },
 	{ .name = "max8997-led", .id = 2 },
 };