diff mbox series

[5/5] usb: dwc3: qcom: Allow runtime PM

Message ID 20230325165217.31069-6-manivannan.sadhasivam@linaro.org
State New
Headers show
Series usb: dwc3: qcom: Allow runtime PM | expand

Commit Message

Manivannan Sadhasivam March 25, 2023, 4:52 p.m. UTC
dwc3-qcom driver is capable of doing runtime PM on its own, but currently
it requires userspace intervention to enable it. But there is no harm in
letting the driver to enable runtime PM on its own. So let's get rid of the
"pm_runtime_forbid()" and make sure that the dependency is maintained with
child devices using "pm_suspend_ignore_children(dev, false)".

Also during remove(), the device needs to be waken up first if it was
runtime suspended. Finally, pm_runtime_allow() can be removed.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
 drivers/usb/dwc3/dwc3-qcom.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index f1059dfcb0e8..5f26bb66274f 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -920,7 +920,7 @@  static int dwc3_qcom_probe(struct platform_device *pdev)
 	qcom->is_suspended = false;
-	pm_runtime_forbid(dev);
+	pm_suspend_ignore_children(dev, false);
 	return 0;
@@ -948,6 +948,8 @@  static int dwc3_qcom_remove(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	int i;
+	pm_runtime_get_sync(dev);
@@ -960,7 +962,6 @@  static int dwc3_qcom_remove(struct platform_device *pdev)
-	pm_runtime_allow(dev);
 	return 0;