[16/30] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc

Message ID 20200702144625.2533530-17-lee.jones@linaro.org
State Superseded
Headers show
Series
  • Fix a bunch of W=1 issues in USB
Related show

Commit Message

Lee Jones July 2, 2020, 2:46 p.m.
Fixes the following W=1 kernel build warnings:

 drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes]
 13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...)
 | ^~~~~~~~~~~~~~

Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/usb/mtu3/mtu3_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1

Comments

Chunfeng Yun July 3, 2020, 1:41 a.m. | #1
On Thu, 2020-07-02 at 15:46 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warnings:

> 

>  drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes]

>  13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...)

>  | ^~~~~~~~~~~~~~

The description doesn't match with the title and code changes

> 

> Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>

> Cc: linux-mediatek@lists.infradead.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/usb/mtu3/mtu3_trace.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c

> index 4f5e7857ec312..155eae126e5e2 100644

> --- a/drivers/usb/mtu3/mtu3_trace.c

> +++ b/drivers/usb/mtu3/mtu3_trace.c

> @@ -1,5 +1,5 @@

>  // SPDX-License-Identifier: GPL-2.0

> -/**

> +/*

>   * mtu3_trace.c - trace support

>   *

>   * Copyright (C) 2019 MediaTek Inc.

Patch

diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c
index 4f5e7857ec312..155eae126e5e2 100644
--- a/drivers/usb/mtu3/mtu3_trace.c
+++ b/drivers/usb/mtu3/mtu3_trace.c
@@ -1,5 +1,5 @@ 
 // SPDX-License-Identifier: GPL-2.0
-/**
+/*
  * mtu3_trace.c - trace support
  *
  * Copyright (C) 2019 MediaTek Inc.