diff mbox series

[1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe()

Message ID 20210508015310.1627-1-thunder.leizhen@huawei.com
State New
Headers show
Series [1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe() | expand

Commit Message

Zhen Lei May 8, 2021, 1:53 a.m. UTC 
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 drivers/usb/dwc3/dwc3-imx8mp.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1

Comments

Felipe Balbi May 10, 2021, 12:13 p.m. UTC | #1 
Zhen Lei <thunder.leizhen@huawei.com> writes:

> Fix to return a negative error code from the error handling case instead

> of 0, as done elsewhere in this function.

>

> Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>


Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index b13cfab89d53..97810ca17a2c 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -167,6 +167,7 @@  static int dwc3_imx8mp_probe(struct platform_device *pdev)
 
 	dwc3_np = of_get_child_by_name(node, "dwc3");
 	if (!dwc3_np) {
+		err = -ENODEV;
 		dev_err(dev, "failed to find dwc3 core child\n");
 		goto disable_rpm;
 	}