diff mbox series

[v2,4/9] media: ov2740: Improve ov2740_check_hwcfg() error reporting

Message ID 20231126141517.7534-5-hdegoede@redhat.com
State New
Headers show
Series media: ov2740: reset GPIO, clk and 180 MHz link-frequency support | expand

Commit Message

Hans de Goede Nov. 26, 2023, 2:15 p.m. UTC 
Make ov2740_check_hwcfg() report an error on failure in all error paths,
so that it is always clear why the probe() failed.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/media/i2c/ov2740.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
index 832f24721dca..7e31aa2decd0 100644
--- a/drivers/media/i2c/ov2740.c
+++ b/drivers/media/i2c/ov2740.c
@@ -936,7 +936,8 @@  static int ov2740_check_hwcfg(struct device *dev)
 
 	ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
 	if (ret)
-		return ret;
+		return dev_err_probe(dev, ret,
+				     "reading clock-frequency property\n");
 
 	if (mclk != OV2740_MCLK)
 		return dev_err_probe(dev, -EINVAL,
@@ -946,7 +947,7 @@  static int ov2740_check_hwcfg(struct device *dev)
 	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
 	fwnode_handle_put(ep);
 	if (ret)
-		return ret;
+		return dev_err_probe(dev, ret, "parsing endpoint failed\n");
 
 	if (bus_cfg.bus.mipi_csi2.num_data_lanes != OV2740_DATA_LANES) {
 		ret = dev_err_probe(dev, -EINVAL,