| Message ID | 20210407031137.2750993-1-weiyongjun1@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next,v2] i2c: designware: Fix return value check in navi_amd_register_client() | expand |
Hi Wei, On 07-Apr-21 8:41, Wei Yongjun wrote: > [CAUTION: External Email] > > In case of error, the function i2c_new_client_device() returns > ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > v1 -> v2: fix description format. > --- > drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c > index 7ca0017883a6..0f409a4c2da0 100644 > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > @@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev) > info.irq = dev->irq; > > dev->slave = i2c_new_client_device(&dev->adapter, &info); > - if (!dev->slave) > - return -ENODEV; > + if (IS_ERR(dev->slave)) > + return PTR_ERR(dev->slave); I got your point, applying mentioned change in my patch. > > return 0; > } > Thanks, Sanket
On Wed, Apr 07, 2021 at 03:11:37AM +0000, Wei Yongjun wrote: > In case of error, the function i2c_new_client_device() returns > ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 7ca0017883a6..0f409a4c2da0 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev) info.irq = dev->irq; dev->slave = i2c_new_client_device(&dev->adapter, &info); - if (!dev->slave) - return -ENODEV; + if (IS_ERR(dev->slave)) + return PTR_ERR(dev->slave); return 0; }
In case of error, the function i2c_new_client_device() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- v1 -> v2: fix description format. --- drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)